[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(s) 8154529: some places in the invoke.c that use InvokeRequest* not protected with invokerLo
From:       Severin Gehwolf <sgehwolf () redhat ! com>
Date:       2016-04-26 11:22:39
Message-ID: 1461669759.3372.26.camel () redhat ! com
[Download RAW message or body]

Hi Serguei,

On Tue, 2016-04-26 at 02:35 -0700, serguei.spitsyn@oracle.com wrote:
> Hi Severin,
> 
> It looks good.
> Thank you for taking care.
> I can sponsor the fix after it is reviewed.

Thanks for the review!

The hg exported changeset is here:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8154529/JDK-8154529-jdk9-jdk.export.patch

Cheers,
Severin

> Thanks,
> Serguei
> 
> 
> On 4/26/16 01:58, Severin Gehwolf wrote:
> > 
> > Hi,
> > 
> > Could somebody please review this patch for JDK-8154529. Some
> > methods
> > modifying values pointed to by the InvokeRequest pointer aren't
> > holding
> > the invokerLock. This can lead to some races. For example between
> > invoker_doInvoke() and threadControl_popFrames().
> > 
> > Perhaps com/sun/jdi/PopAndInvokeTest.java can be enabled (un-
> > ignored)
> > these days?
> > 
> > There was also one instance of dead code: invoker_isPending() isn't
> > used anywhere.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8154529
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8154529/we
> > brev.01/
> > 
> > Testing done:
> >    - com/sun/jdi test set. No regressions.
> >    - I've also run the following invoke tests 1500 times with no
> > failures:
> >         com/sun/jdi/InterfaceMethodsTest.java
> >         com/sun/jdi/InvokeTest.java
> >         com/sun/jdi/InvokeHangTest.java
> > 
> > Thoughts? Once reviewed, I'd need somebody to sponsor this patch
> > for
> > me.
> > 
> > Thanks,
> > Severin

[prev in list] [next in list] [prev in thread] [next in thread]