[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: JDK 9 RFR of JDK-8154277: JavaDoc warnings in VirtualMachineManager.java and Pool.java
From:       joe darcy <joe.darcy () oracle ! com>
Date:       2016-04-22 22:18:15
Message-ID: 571AA327.7000208 () oracle ! com
[Download RAW message or body]

On 4/22/2016 1:09 AM, Alan Bateman wrote:
>
> On 22/04/2016 09:06, Amy Lu wrote:
>> Please review this tiny fix for typos in the the documentation of:
>>
>> jdk/src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/Pool.java
>> jdk/src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachineManager.java
>>
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8154277
>> webrev: http://cr.openjdk.java.net/~amlu/8154277/webrev.00/
>>
>> Thanks,
>> Amy
> Looks good. In the case of the jlink API then the javadoc was clean at 
> one point but it seems to have regressed.
>

I took a quick look at the makefile and didn't see a specialized entry 
for jdk.jlink. In any case, I recommend the build options for jdk.jlink, 
wherever they are, to be modified to make lint and doclint warnings fatal.

Cheers,

-Joe

[prev in list] [next in list] [prev in thread] [next in thread]