[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR : JDK-8151797 - java/lang/management/ThreadMXBean/ThreadLists.java : inconsistent
From: Harsha Wardhana B <harsha.wardhana.b () oracle ! com>
Date: 2016-03-22 5:21:28
Message-ID: 56F0D388.8050807 () oracle ! com
[Download RAW message or body]
Hello Serguei,
So far Staffan is the only reviewer.
Thanks
Harsha
On Tuesday 22 March 2016 07:47 AM, serguei.spitsyn@oracle.com wrote:
> Hi Harsha,
>
> Who are reviewers, only Staffan or there are more?
>
> Thanks,
> Serguei
>
>
> On 3/20/16 21:10, Harsha Wardhana B wrote:
>> Hello,
>>
>> Please review the new patch located at,
>>
>> http://cr.openjdk.java.net/~hb/8151797/webrev.01/
>>
>> -Harsha
>>
>> On Friday 18 March 2016 05:01 PM, Staffan Larsen wrote:
>>> You should move the Arrays.stream trigger call to before
>>> the ManagementFactory.getThreadMXBean, otherwise the threads you get
>>> from ThreadMXBean will not match the threads you get from the
>>> ThreadGroups.
>>>
>>>> On 18 mars 2016, at 12:17, Harsha Wardhana B
>>>> <harsha.wardhana.b@oracle.com
>>>> <mailto:harsha.wardhana.b@oracle.com>> wrote:
>>>>
>>>> Hello All,
>>>>
>>>> Please review fix for,
>>>>
>>>> Issue : JDK-8151797 <http://jdk-8151797/> -
>>>> java/lang/management/ThreadMXBean/ThreadLists.java : inconsistent
>>>> results
>>>> Webrev : http://cr.openjdk.java.net/~hb/8151797/webrev.00/
>>>>
>>>> Root-cause : call-site cleaner thread not started before counting
>>>> threads via Thread.getAllStackTraces();.
>>>> Fix : Create ThreadMXBean at the beginning of test so that
>>>> call-site cleaner thread will be started.
>>>>
>>>> Thanks
>>>> Harsha
>>>>
>>>
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Serguei,<br>
<br>
So far Staffan is the only reviewer. <br>
<br>
Thanks<br>
Harsha<br>
<br>
<div class="moz-cite-prefix">On Tuesday 22 March 2016 07:47 AM,
<a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br> \
</div> <blockquote cite="mid:56F0AB53.3050504@oracle.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Harsha,<br>
<br>
Who are reviewers, only Staffan or there are more?<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 3/20/16 21:10, Harsha Wardhana B wrote:<br>
</div>
<blockquote cite="mid:56EF7441.8010306@oracle.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Hello,<br>
<br>
Please review the new patch located at,<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ehb/8151797/webrev.01/">http://cr.openjdk.java.net/~hb/8151797/webrev.01/</a><br>
<br>
-Harsha<br>
<br>
<div class="moz-cite-prefix">On Friday 18 March 2016 05:01 PM,
Staffan Larsen wrote:<br>
</div>
<blockquote
cite="mid:0F53E9D3-2FC8-4C23-88EB-4F2C0BF0A039@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
You should move the Arrays.stream trigger call to before
the ManagementFactory.getThreadMXBean, otherwise the threads
you get from ThreadMXBean will not match the threads you get
from the ThreadGroups.
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 18 mars 2016, at 12:17, Harsha Wardhana
B <<a moz-do-not-send="true"
href="mailto:harsha.wardhana.b@oracle.com" \
class="">harsha.wardhana.b@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252" class="">
<div bgcolor="#FFFFFF" text="#000000" class=""> Hello
All,<br class="">
<br class="">
Please review fix for,<br class="">
<br class="">
Issue : <a moz-do-not-send="true"
href="http://jdk-8151797/" class="">JDK-8151797</a>
-
java/lang/management/ThreadMXBean/ThreadLists.java :
inconsistent results<br class="">
Webrev : <a moz-do-not-send="true"
class="moz-txt-link-freetext"
\
href="http://cr.openjdk.java.net/%7Ehb/8151797/webrev.00/">http://cr.openjdk.java.net/~hb/8151797/webrev.00/</a><br
class="">
<br class="">
Root-cause : call-site cleaner thread not started
before counting threads via
Thread.getAllStackTraces();. <br class="">
Fix : Create ThreadMXBean at the beginning of test
so that call-site cleaner thread will be started. <br
class="">
<br class="">
Thanks<br class="">
Harsha<br class="">
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic