[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: RFR [9] 8150168: jconsole AboutDialog should use the JDK specific Version API
From:       Iris Clark <iris.clark () oracle ! com>
Date:       2016-02-18 21:37:14
Message-ID: a361e275-d12d-4245-ad00-e0261b8d2543 () default
[Download RAW message or body]

Hi, Chris.

I think that change is fine.  

I've added a note to JDK-8144062 (module for jdk.Version), indicating that this code \
may need to be changed depending on how that issue is resolved.

Thanks,
iris

-----Original Message-----
From: Chris Hegarty 
Sent: Thursday, February 18, 2016 5:42 AM
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: RFR [9] 8150168: jconsole AboutDialog should use the JDK specific Version \
API

With the introduction of a JDK specific Version API, the console AboutDialog should \
no longer use sun.misc.Version. It should be be updated to use the new JDK specific \
API. 

diff --git a/src/jdk.jconsole/share/classes/sun/tools/jconsole/AboutDialog.java \
                b/src/jdk.jconsole/share/classes/sun/tools/jconsole/AboutDialog.java
--- a/src/jdk.jconsole/share/classes/sun/tools/jconsole/AboutDialog.java 
+++ b/src/jdk.jconsole/share/classes/sun/tools/jconsole/AboutDialog.java
@@ -34,8 +34,6 @@
 import javax.swing.border.*;
 import javax.swing.event.*; 
  
-import static sun.misc.Version.jdkMinorVersion;
-
 import static java.awt.BorderLayout.*;  import static \
sun.tools.jconsole.Utilities.*;   
@@ -183,7 +181,7 @@ 
     } 
  
     private static String getOnlineDocUrl() {
- String version = Integer.toString(jdkMinorVersion()); 
+ String version = Integer.toString(jdk.Version.current().major());
         return Resources.format(Messages.HELP_ABOUT_DIALOG_USER_GUIDE_LINK_URL, 
                                 version); 
     }

-Chris.

https://bugs.openjdk.java.net/browse/JDK-8150168


[prev in list] [next in list] [prev in thread] [next in thread]