[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: Fwd: Re: [8u] RFR: 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy
From: Andreas Eriksson <andreas.eriksson () oracle ! com>
Date: 2016-02-16 14:06:03
Message-ID: 56C32CCB.6040803 () oracle ! com
[Download RAW message or body]
Hi,
Anyone with 8u Reviewer status who can take a look?
- Andreas
On 2016-02-10 19:01, Andreas Eriksson wrote:
> [Adding jdk8u-dev list]
>
> Hi,
>
> I believe I need an 8u Reviewer as well, since Dmitry is only
> committer for 8u?
> Could someone please take a look?
>
> This is type cleanup for dumping a heap with long arrays.
>
> Hotspot webrev:
> http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/hotspot/
> JDK webrev:
> http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/jdk/
>
> See below for changes compared to the JDK 9 version.
>
> Regards,
> Andreas
>
>
> -------- Forwarded Message --------
> Subject: Re: [8u] RFR: 8129419: heapDumper.cpp:
> assert(length_in_bytes > 0) failed: nothing to copy
> Date: Wed, 10 Feb 2016 20:38:21 +0300
> From: Dmitry Samersoff <dmitry.samersoff@oracle.com>
> To: Andreas Eriksson <andreas.eriksson@oracle.com>,
> serviceability-dev@openjdk.java.net
>
>
>
> Andreas,
>
> Looks good for me!
>
> -Dmitry
>
> On 2016-01-28 20:36, Andreas Eriksson wrote:
> > Hi,
> >
> > Please review this backport of JDK-8129419
> ><https://bugs.openjdk.java.net/browse/JDK-8129419>.
> >
> > Hotspot webrev:
> >http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/hotspot/
> > JDK webrev:http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/jdk/
> >
> > There are three changes compared to JDK 9:
> >
> > 1) The hprof parser is in the JDK repo instead of top repo.
> > Otherwise these changes are the same.
> >
> > 2) On Solaris os::write has some UseVMInterruptibleIO logic that failed
> > because it assumed it was called by a JavaThread.
> > I changed it to skip UseVMInterruptibleIO logic if called by a
> > non-JavaThread.
> >
> > 3) The "heap dump file created" message were using sprintf and pragmas
> > because of legacy reasons.
> > Code after the change is the same as JDK 9 code.
> >
> > Regards,
> > Andreas
>
>
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi,<br>
<br>
Anyone with 8u Reviewer status who can take a look?<br>
<br>
- Andreas<br>
<br>
<br>
<div class="moz-cite-prefix">On 2016-02-10 19:01, Andreas Eriksson
wrote:<br>
</div>
<blockquote cite="mid:56BB7AFD.4090800@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
[Adding jdk8u-dev list]<br>
<br>
Hi,<br>
<br>
I believe I need an 8u Reviewer as well, since Dmitry is only
committer for 8u?<br>
Could someone please take a look?<br>
<br>
This is type cleanup for dumping a heap with long arrays.<br>
<br>
Hotspot webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eaeriksso/8129419/webrev.jdk8.00/hotspot/">http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/hotspot/</a><br>
JDK webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eaeriksso/8129419/webrev.jdk8.00/jdk/">http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/jdk/</a><br>
<br>
See below for changes compared to the JDK 9 version.<br>
<br>
Regards,<br>
Andreas<br>
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" border="0"
cellpadding="0" cellspacing="0">
<tbody>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Subject:
</th>
<td>Re: [8u] RFR: 8129419: heapDumper.cpp:
assert(length_in_bytes > 0) failed: nothing to copy</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Date:
</th>
<td>Wed, 10 Feb 2016 20:38:21 +0300</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">From:
</th>
<td>Dmitry Samersoff <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:dmitry.samersoff@oracle.com"><dmitry.samersoff@oracle.com></a></td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">To: </th>
<td>Andreas Eriksson <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:andreas.eriksson@oracle.com"><andreas.eriksson@oracle.com></a>,
<a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>Andreas,
Looks good for me!
-Dmitry
On 2016-01-28 20:36, Andreas Eriksson wrote:
> Hi,
>
> Please review this backport of JDK-8129419
> <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" \
href="https://bugs.openjdk.java.net/browse/JDK-8129419"><https://bugs.openjdk.java.net/browse/JDK-8129419></a>.
>
> Hotspot webrev:
> <a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eaeriksso/8129419/webrev.jdk8.00/hotspot/">http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/hotspot/</a>
> JDK webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Eaeriksso/8129419/webrev.jdk8.00/jdk/">http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/jdk/</a>
>
> There are three changes compared to JDK 9:
>
> 1) The hprof parser is in the JDK repo instead of top repo.
> Otherwise these changes are the same.
>
> 2) On Solaris os::write has some UseVMInterruptibleIO logic that failed
> because it assumed it was called by a JavaThread.
> I changed it to skip UseVMInterruptibleIO logic if called by a
> non-JavaThread.
>
> 3) The "heap dump file created" message were using sprintf and pragmas
> because of legacy reasons.
> Code after the change is the same as JDK 9 code.
>
> Regards,
> Andreas
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
</pre>
<br>
</div>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic