[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [8u] RFR: 8129419: heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy
From:       Andreas Eriksson <andreas.eriksson () oracle ! com>
Date:       2016-02-10 17:40:33
Message-ID: 56BB7611.60500 () oracle ! com
[Download RAW message or body]

Thanks!

- Andreas

On 2016-02-10 18:38, Dmitry Samersoff wrote:
> Andreas,
>
> Looks good for me!
>
> -Dmitry
>
> On 2016-01-28 20:36, Andreas Eriksson wrote:
>> Hi,
>>
>> Please review this backport of JDK-8129419
>> <https://bugs.openjdk.java.net/browse/JDK-8129419>.
>>
>> Hotspot webrev:
>> http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/hotspot/
>> JDK webrev: http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/jdk/
>>
>> There are three changes compared to JDK 9:
>>
>> 1) The hprof parser is in the JDK repo instead of top repo.
>> Otherwise these changes are the same.
>>
>> 2) On Solaris os::write has some UseVMInterruptibleIO logic that failed
>> because it assumed it was called by a JavaThread.
>> I changed it to skip UseVMInterruptibleIO logic if called by a
>> non-JavaThread.
>>
>> 3) The "heap dump file created" message were using sprintf and pragmas
>> because of legacy reasons.
>> Code after the change is the same as JDK 9 code.
>>
>> Regards,
>> Andreas
>

[prev in list] [next in list] [prev in thread] [next in thread]