[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR(xs): 8149096: Remove unused code in methodComparator
From: Thomas_Stüfe <thomas.stuefe () gmail ! com>
Date: 2016-02-09 9:36:41
Message-ID: CAA-vtUyQWYP=gT8GpTgFrO=au_5EPVxZgNqNQ+CF50K=+FjY=Q () mail ! gmail ! com
[Download RAW message or body]
Hi all,
thanks to all for your feedback. Here is the new webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-metho=
dComparator/webrev.01/webrev/index.html
I removed _switchable_test and all code dependending from it.
Thomas
On Tue, Feb 9, 2016 at 7:17 AM, serguei.spitsyn@oracle.com <
serguei.spitsyn@oracle.com> wrote:
> On 2/8/16 20:20, David Holmes wrote:
>
>> On 9/02/2016 5:22 AM, serguei.spitsyn@oracle.com wrote:
>>
>>> Hi Thomas,
>>>
>>> The fix looks good.
>>> The following variable and all its uses are dead too as it never gets
>>> 'true' value.
>>>
>>
>> I think _switchable_test is the variable Serguei was referring to.
>>
>
> Yes.
> I forgot to paste the variable name. :)
>
>
> Thanks,
> Serguei
>
>
>
> The whole notion of switchability is "dead" now so all code that relates
>> to _switchable_test being true is also dead. Also any comment use of
>> switchable.
>>
>> But it is up to you to fix it or not.
>>>
>>
>> I'd like to see it all cleaned up please. :)
>>
>> Thanks,
>> David
>>
>>
>>> I can sponsor and push the fix.
>>>
>>> Thank you for taking care about this.
>>> Serguei
>>>
>>>
>>> On 2/8/16 06:24, Thomas St=C3=BCfe wrote:
>>>
>>>> Hi all,
>>>>
>>>> please review and sponsor this little change. It gets rid of two
>>>> unused methods in methodComparator(cpp/hpp).
>>>>
>>>> We stumbled over this because of warings about unchecked realloc()
>>>> return values; but instead of fixing the code, we may just remove the
>>>> offending methods, because they are not used anywhere.
>>>>
>>>> See also mail thread here:
>>>>
>>>> http://openjdk.5641.n7.nabble.com/Unused-code-in-prims-methodComparato=
r-td254425.html.
>>>>
>>>>
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8149096
>>>>
>>>> webrev:
>>>>
>>>> http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-=
methodComparator/webrev.00/webrev/
>>>> <
>>>> http://cr.openjdk.java.net/%7Estuefe/webrevs/8149096-remove-unused-cod=
e-methodComparator/webrev.00/webrev/>
>>>>
>>>>
>>>>
>>>> Kind Regards, Thomas
>>>>
>>>
>>>
>
[Attachment #3 (text/html)]
<div dir="ltr">Hi all,<div><br></div><div>thanks to all for your feedback. Here is \
the new webrev:</div><div><br></div><div><a \
href="http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-methodComp \
arator/webrev.01/webrev/index.html">http://cr.openjdk.java.net/~stuefe/webrevs/8149096 \
-remove-unused-code-methodComparator/webrev.01/webrev/index.html</a></div><div><br></div><div>I \
removed _switchable_test and all code dependending from \
it.</div><div><br></div><div>Thomas<br><div class="gmail_extra"><br><div \
class="gmail_quote">On Tue, Feb 9, 2016 at 7:17 AM, <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> <span \
dir="ltr"><<a href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span \
class="">On 2/8/16 20:20, David Holmes wrote:<br> <blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On 9/02/2016 5:22 AM, <a href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hi Thomas,<br>
<br>
The fix looks good.<br>
The following variable and all its uses are dead too as it never gets<br>
'true' value.<br>
</blockquote>
<br>
I think _switchable_test is the variable Serguei was referring to.<br>
</blockquote>
<br></span>
Yes.<br>
I forgot to paste the variable name. :)<br>
<br>
<br>
Thanks,<br>
Serguei<div class=""><div class="h5"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
The whole notion of switchability is "dead" now so all code that relates \
to _switchable_test being true is also dead. Also any comment use of switchable.<br> \
<br> <blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
But it is up to you to fix it or not.<br>
</blockquote>
<br>
I'd like to see it all cleaned up please. :)<br>
<br>
Thanks,<br>
David<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
I can sponsor and push the fix.<br>
<br>
Thank you for taking care about this.<br>
Serguei<br>
<br>
<br>
On 2/8/16 06:24, Thomas Stüfe wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hi all,<br>
<br>
please review and sponsor this little change. It gets rid of two<br>
unused methods in methodComparator(cpp/hpp).<br>
<br>
We stumbled over this because of warings about unchecked realloc()<br>
return values; but instead of fixing the code, we may just remove the<br>
offending methods, because they are not used anywhere.<br>
<br>
See also mail thread here:<br>
<a href="http://openjdk.5641.n7.nabble.com/Unused-code-in-prims-methodComparator-td254425.html" \
rel="noreferrer" target="_blank">http://openjdk.5641.n7.nabble.com/Unused-code-in-prims-methodComparator-td254425.html</a>. \
<br> <br>
<br>
bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8149096" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8149096</a><br> <br>
webrev:<br>
<a href="http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/</a> \
<br> <<a href="http://cr.openjdk.java.net/%7Estuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/%7Estuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/</a>> \
<br> <br>
<br>
Kind Regards, Thomas<br>
</blockquote>
<br>
</blockquote></blockquote>
<br>
</div></div></blockquote></div><br></div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic