[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8147348: LogTagLevelExpression not properly initialized in configure_stdout
From:       Marcus Larsson <marcus.larsson () oracle ! com>
Date:       2016-01-27 8:11:34
Message-ID: 56A87BB6.2080005 () oracle ! com
[Download RAW message or body]

Thanks Staffan!

Marcus

On 01/27/2016 08:56 AM, Staffan Larsen wrote:
> Looks good!
> 
> Thanks,
> /Staffan
> 
> > On 21 jan. 2016, at 11:42, Marcus Larsson <marcus.larsson@oracle.com> wrote:
> > 
> > Hi,
> > 
> > Please review the following patch to fix an initialization error in \
> > LogTagLevelExpression. If not using the parse() method (as is the case in \
> > LogConfiguration::configure_stdout) instances of the class would not be properly \
> > initialized. 
> > The clear() method has been removed and the necessary initialization is now done \
> > in the constructor instead. An internal VM test has been added for \
> > configure_stdout. 
> > Webrev:
> > http://cr.openjdk.java.net/~mlarsson/8147348/webrev.00/
> > 
> > Issue:
> > https://bugs.openjdk.java.net/browse/JDK-8147348
> > 
> > Testing:
> > New test through JPRT
> > 
> > Thanks,
> > Marcus


[prev in list] [next in list] [prev in thread] [next in thread]