[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: Review of JDK-6659240 - Exceptions thrown by MXBeans wrongly documented in j.l.m.ManagementFacto
From:       Jaroslav Bachorik <jaroslav.bachorik () oracle ! com>
Date:       2016-01-18 9:28:37
Message-ID: 569CB045.9060906 () oracle ! com
[Download RAW message or body]

On 18.1.2016 10:23, Sharath Ballal wrote:
> Hello,
> Following is the link with all the comments incorporated, kindly review the same.
> 
> http://cr.openjdk.java.net/~jbachorik/sponsorship/6659240/webrev.02/

Thumbs up! bd

> 
> 
> -Sharath Ballal
> 
> 
> 
> -----Original Message-----
> From: Daniel Fuchs
> Sent: Thursday, January 07, 2016 7:43 PM
> To: Sharath Ballal; Jaroslav Bachorik; serviceability-dev@openjdk.java.net
> Subject: Re: Review of JDK-6659240 - Exceptions thrown by MXBeans wrongly \
> documented in j.l.m.ManagementFactory 
> Hi,
> 
> 524      * An application remotely accessing the platform MXBeans using
> 525      * proxy should prepare to catch {@code
> UndeclaredThrowableException} as if
> 526      * accessing with the {@code MBeanServerConnector} interface.</li>
> 
> I find this text confusing.
> 
> 1. It's not clear what the {@code MBeanServerConnector} interface is.
> I suspect this is a typo?
> 2. If this is a typo and {@code MBeanServerConnection} was intended,
> then the text above is confusing since MBeanServerConnection
> will not throw UndeclaredThrowableException.
> 
> Maybe something like:
> 
> * An application remotely accessing the platform MXBeans using
> * proxy should prepare to catch {@code UndeclaredThrowableException}
> * and handle its {@linkplain UndeclaredThrowableException#getCause()
> * cause} as if that cause had been thrown by the
> * {@code MBeanServerConnection} interface.
> 
> best regards,
> 
> -- daniel
> 
> On 07/01/16 11:06, Sharath Ballal wrote:
> > Hi,
> > CCC request is approved with some changes (http://ccc.us.oracle.com/6659240).  \
> > Following is the link with the modifications: 
> > http://cr.openjdk.java.net/~jbachorik/sponsorship/6659240/webrev.01/
> > 
> > Kindly review the same.
> > 
> > -Sharath Ballal
> > 
> > 
> > 
> > -----Original Message-----
> > From: Jaroslav Bachorik
> > Sent: Wednesday, December 30, 2015 2:36 PM
> > To: serviceability-dev@openjdk.java.net
> > Subject: Re: Review of JDK-6659240 - Exceptions thrown by MXBeans wrongly \
> > documented in j.l.m.ManagementFactory 
> > On 28.12.2015 18:01, Sharath Ballal wrote:
> > > Hi,
> > > 
> > > Kindly review the changes for bug
> > > https://bugs.openjdk.java.net/browse/JDK-6659240
> > > 
> > > Webrev: http://cr.openjdk.java.net/~jbachorik/sponsorship/6659240/webrev.00/
> > 
> > Looks good!
> > 
> > -JB-
> > 
> > > 
> > > CCC request for the same is being raised in parallel.
> > > 
> > > -Sharath Ballal
> > > 
> > 
> 


[prev in list] [next in list] [prev in thread] [next in thread]