[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8145408: "com/sun/jdi/BreakpointWithFullGC.sh: Required output "Full GC" not found"
From:       Alexander Kulyakhtin <alexander.kulyakhtin () oracle ! com>
Date:       2015-12-16 16:11:05
Message-ID: 0af0d61f-30be-41c8-93d5-88d26df77318 () default
[Download RAW message or body]

Daniel,

Thank you very much for the review. I'm going to add the comment as you hav=
e suggested.

Best regards,
Alexander

----- Original Message -----
From: daniel.daugherty@oracle.com
To: alexander.kulyakhtin@oracle.com, serviceability-dev@openjdk.java.net
Sent: Wednesday, December 16, 2015 5:58:03 PM GMT +03:00 Iraq
Subject: Re: RFR: 8145408: "com/sun/jdi/BreakpointWithFullGC.sh: Required o=
utput "Full GC" not found"

You might want to include a comment like:

# Prior to JDK9-BNN, the pattern was 'Full GC'

where NN is the promoted build where the format changed.
This will help anyone backporting test fixes to older releases.

Dan

On 12/16/15 5:05 AM, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review this small test-only fix:
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8145408 "com/sun/jdi/Breakpo=
intWithFullGC.sh: Required output "Full GC" not found"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8145408/test/com/sun/jdi/Bre=
akpointWithFullGC.sh.udiff.html
>
> The test, among other things, verifies that an indication of a Full GC ev=
ent is present in the output.
>
> Recently, such an indication has been changed from similar to:
> [Full GC (System.gc())  2663K->2663K(31744K), 0.0034321 secs]
>
> to similar to:
> [3.326s][info   ][gc] GC(10) Pause Full (System.gc()) 11M->3M(12M) (3.312=
s, 3.326s) 14.405ms
>
> We are changing the matcher correspondingly, also making it more precise.
>
> Best regards,
> Alexander

[prev in list] [next in list] [prev in thread] [next in thread]