[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: [PING] RFR (XS): 8142483: Unified logging log instances cause warnings on windows when only stat
From: Staffan Larsen <staffan.larsen () oracle ! com>
Date: 2015-11-20 12:38:47
Message-ID: D06536C9-773A-438A-9884-6385091ADB50 () oracle ! com
[Download RAW message or body]
Looks good!
Thanks,
/Staffan
> On 20 nov. 2015, at 13:29, Marcus Larsson <marcus.larsson@oracle.com> wrote:
>
> Need another review for this!
>
> Thanks,
> Marcus
>
> On 2015-11-13 10:20, Marcus Larsson wrote:
> > Hi,
> >
> > Please review the following small patch to avoid 'unused variable' warnings on \
> > windows when only static functions are used on a log instance. Using log \
> > instances like this saves us from specifying the log tags for every function \
> > call, so it is something we should not warn about.
> > The patch adds an empty constructor, which means that at least one non-static \
> > function is called for every log instance, and the warning is avoided.
> > Webrev:
> > http://cr.openjdk.java.net/~mlarsson/8142483/webrev.00/ \
> > <http://cr.openjdk.java.net/%7Emlarsson/8142483/webrev.00/>
> > Issue:
> > https://bugs.openjdk.java.net/browse/JDK-8142483 \
> > <https://bugs.openjdk.java.net/browse/JDK-8142483>
> > Thanks,
> > Marcus
>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;" class=""><div class="">Looks \
good!</div><div class=""><br class=""></div><div class="">Thanks,</div><div \
class="">/Staffan</div><div class=""><br class=""></div><div><blockquote type="cite" \
class=""><div class="">On 20 nov. 2015, at 13:29, Marcus Larsson <<a \
href="mailto:marcus.larsson@oracle.com" class="">marcus.larsson@oracle.com</a>> \
wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
Need another review for this!<br class="">
<br class="">
Thanks,<br class="">
Marcus<br class="">
<br class="">
<div class="moz-cite-prefix">On 2015-11-13 10:20, Marcus Larsson
wrote:<br class="">
</div>
<blockquote cite="mid:5645AB4F.40907@oracle.com" type="cite" class="">
<meta http-equiv="content-type" content="text/html; charset=utf-8" class="">
Hi,<br class="">
<br class="">
Please review the following small patch to avoid 'unused variable'
warnings on windows when only static functions are used on a log
instance. Using log instances like this saves us from specifying
the log tags for every function call, so it is something we should
not warn about.<br class="">
<br class="">
The patch adds an empty constructor, which means that at least one
non-static function is called for every log instance, and the
warning is avoided.<br class="">
<br class="">
Webrev:<br class="">
<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Emlarsson/8142483/webrev.00/">http://cr.openjdk.java.net/~mlarsson/8142483/webrev.00/</a><br \
class=""> <br class="">
Issue:<br class="">
<meta http-equiv="content-type" content="text/html; charset=utf-8" class="">
<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8142483">https://bugs.openjdk.java.net/browse/JDK-8142483</a><br \
class=""> <br class="">
Thanks,<br class="">
Marcus<br class="">
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic