[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8143235: Remove libjfr mapfile
From:       Jaroslav Bachorik <jaroslav.bachorik () oracle ! com>
Date:       2015-11-20 10:03:19
Message-ID: 564EEFE7.6030308 () oracle ! com
[Download RAW message or body]

Looks good!

-JB-

On 18.11.2015 21:09, Markus Gronlund wrote:
> Greetings,
>
> Kindly asking for reviews for the following:
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8143235
>
> Summary:
>
> Remove libjfr mapfile (cleanup) + adds "jdk.management.jfr" to boot modules
>
> Patch is attached and also unrolled here:
>
> # HG changeset patch
>
> # User mgronlun
>
> # Date 1447765226 -3600
>
> #      Tue Nov 17 14:00:26 2015 +0100
>
> # Node ID 13e7746e92f9b9651c0f77ed04057f382cc9e477
>
> # Parent  85c9ddeda1c3fe13ef64ce1005c09af8e0bf1f42
>
> [mq]: jdk_src_open_remove_mapfile
>
> diff --git a/make/mapfiles/libjfr/mapfile-vers
> b/make/mapfiles/libjfr/mapfile-vers
>
> deleted file mode 100644
>
> --- a/make/mapfiles/libjfr/mapfile-vers
>
> +++ /dev/null
>
> @@ -1,45 +0,0 @@
>
> -#
>
> -# Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights
> reserved.
>
> -# ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.
>
> -#
>
> -
>
> -# Define library interface.
>
> -
>
> -SUNWprivate_1.1 {
>
> -  global:
>
> -      Java_oracle_jrockit_jfr_Process_getpid;
>
> -      Java_oracle_jrockit_jfr_Timing_counterTime;
>
> -      Java_oracle_jrockit_jfr_Timing_init;
>
> -      Java_oracle_jrockit_jfr_Logger_output0;
>
> -      Java_oracle_jrockit_jfr_JFR_isCommercialFeaturesUnlocked;
>
> -      Java_oracle_jrockit_jfr_JFR_isStarted;
>
> -      Java_oracle_jrockit_jfr_JFR_isSupportedInVM;
>
> -      Java_oracle_jrockit_jfr_JFR_startFlightRecorder;
>
> -      Java_oracle_jrockit_jfr_JFR_isDisabledOnCommandLine;
>
> -      Java_oracle_jrockit_jfr_JFR_isEnabled;
>
> -      Java_oracle_jrockit_jfr_VMJFR_options;
>
> -      Java_oracle_jrockit_jfr_VMJFR_init;
>
> -      Java_oracle_jrockit_jfr_VMJFR_addConstPool;
>
> -      Java_oracle_jrockit_jfr_VMJFR_removeConstPool;
>
> -      Java_oracle_jrockit_jfr_VMJFR_storeConstPool;
>
> -      Java_oracle_jrockit_jfr_VMJFR_classID0;
>
> -      Java_oracle_jrockit_jfr_VMJFR_stackTraceID;
>
> -      Java_oracle_jrockit_jfr_VMJFR_threadID;
>
> -      Java_oracle_jrockit_jfr_VMJFR_rotate;
>
> -      Java_oracle_jrockit_jfr_VMJFR_shutdown;
>
> -      Java_oracle_jrockit_jfr_VMJFR_start;
>
> -      Java_oracle_jrockit_jfr_VMJFR_stop;
>
> -      Java_oracle_jrockit_jfr_VMJFR_buffer;
>
> -      Java_oracle_jrockit_jfr_VMJFR_flush;
>
> -      Java_oracle_jrockit_jfr_VMJFR_write;
>
> -      Java_oracle_jrockit_jfr_VMJFR_add;
>
> -      Java_oracle_jrockit_jfr_VMJFR_remove;
>
> -      Java_oracle_jrockit_jfr_VMJFR_setThreshold;
>
> -      Java_oracle_jrockit_jfr_VMJFR_setPeriod;
>
> -      Java_oracle_jrockit_jfr_VMJFR_getPeriod;
>
> -      Java_oracle_jrockit_jfr_VMJFR_descriptors;
>
> -      Java_oracle_jrockit_jfr_VMJFR_retransformClasses0;
>
> -      JNI_OnLoad;
>
> -  local:
>
> -      *;
>
> -};
>
> diff --git a/make/src/classes/build/tools/module/boot.modules
> b/make/src/classes/build/tools/module/boot.modules
>
> --- a/make/src/classes/build/tools/module/boot.modules
>
> +++ b/make/src/classes/build/tools/module/boot.modules
>
> @@ -23,6 +23,7 @@
>
> jdk.jfr
>
> jdk.management
>
> jdk.management.cmm
>
> +jdk.management.jfr
>
> jdk.management.resource
>
> jdk.naming.rmi
>
> jdk.sctp
>

[prev in list] [next in list] [prev in thread] [next in thread]