[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8066814: Reduce accessibility in TraceEvent
From:       Erik Gahlin <erik.gahlin () oracle ! com>
Date:       2015-11-19 15:21:45
Message-ID: 564DE909.3070303 () oracle ! com
[Download RAW message or body]

Looks good, not a reviewer.

Erik

On 2014-12-17 15:45, Markus Grönlund wrote:
>
> Greetings,
>
> Kindly asking for reviews for the following changeset:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8066814
>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/ 
> <http://cr.openjdk.java.net/%7Emgronlun/8066814/webrev01/>
>
> Description:
>
> TraceEvent currently exposes internals unnecessarily.
>
> Therefore:
>
> Remove unnecessarily exposed methods.
> Add assert for not committing a cancelled event.
> Add method stubs for !INCLUDE_TRACE
>
> Thanks in advance
>
> Markus
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Looks good, not a reviewer.<br>
      <br>
      Erik<br>
      <br>
      On 2014-12-17 15:45, Markus Grönlund wrote:<br>
    </div>
    <blockquote cite="mid:2c9d1e54-7ee2-444d-8ee2-36fefb866f78@default"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      <meta name="Generator" content="Microsoft Word 12 (filtered
        medium)">
      <style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri","sans-serif";
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
      <div class="WordSection1">
        <p class="MsoNormal"><span lang="EN-US">Greetings,<o:p></o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US">Kindly asking for
            reviews for the following changeset:<o:p></o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US">Bug: <a
              moz-do-not-send="true"
              href="https://bugs.openjdk.java.net/browse/JDK-8066814"><a \
class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8066814">https://bugs.openjdk.java.net/browse/JDK-8066814</a></a>
  <o:p></o:p></span></p>
        <p class="MsoNormal">Webrev: <a moz-do-not-send="true"
            href="http://cr.openjdk.java.net/%7Emgronlun/8066814/webrev01/">http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/</a>
  <o:p></o:p></p>
        <p class="MsoNormal"><o:p> </o:p></p>
        <p class="MsoNormal">Description:<o:p></o:p></p>
        <p class="MsoNormal"><span lang="EN-US">TraceEvent currently
            exposes internals unnecessarily.<o:p></o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US">Therefore:<o:p></o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US">Remove unnecessarily
            exposed methods. <br>
            Add assert for not committing a cancelled event. <br>
            Add method stubs for !INCLUDE_TRACE<o:p></o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US">Thanks in \
                advance<o:p></o:p></span></p>
        <p class="MsoNormal"><span lang="EN-US">Markus<o:p></o:p></span></p>
      </div>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic