[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (XS): 8142483: Unified logging log instances cause warnings on windows when only static func
From:       Bengt Rutisson <bengt.rutisson () oracle ! com>
Date:       2015-11-13 9:39:56
Message-ID: 5645AFEC.3010708 () oracle ! com
[Download RAW message or body]

Hi Marcus,

On 2015-11-13 10:20, Marcus Larsson wrote:
> Hi,
>
> Please review the following small patch to avoid 'unused variable' 
> warnings on windows when only static functions are used on a log 
> instance. Using log instances like this saves us from specifying the 
> log tags for every function call, so it is something we should not 
> warn about.
>
> The patch adds an empty constructor, which means that at least one 
> non-static function is called for every log instance, and the warning 
> is avoided.
>
> Webrev:
> http://cr.openjdk.java.net/~mlarsson/8142483/webrev.00/
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8142483

Looks good.

Bengt

>
> Thanks,
> Marcus


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    Hi Marcus,<br>
    <br>
    <div class="moz-cite-prefix">On 2015-11-13 10:20, Marcus Larsson
      wrote:<br>
    </div>
    <blockquote cite="mid:5645AB4F.40907@oracle.com" type="cite">
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      Hi,<br>
      <br>
      Please review the following small patch to avoid 'unused variable'
      warnings on windows when only static functions are used on a log
      instance. Using log instances like this saves us from specifying
      the log tags for every function call, so it is something we should
      not warn about.<br>
      <br>
      The patch adds an empty constructor, which means that at least one
      non-static function is called for every log instance, and the
      warning is avoided.<br>
      <br>
      Webrev:<br>
      <a moz-do-not-send="true" class="moz-txt-link-freetext"
        href="http://cr.openjdk.java.net/%7Emlarsson/8142483/webrev.00/">http://cr.openjdk.java.net/~mlarsson/8142483/webrev.00/</a><br>
  <br>
      Issue:<br>
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <a moz-do-not-send="true" class="moz-txt-link-freetext"
        href="https://bugs.openjdk.java.net/browse/JDK-8142483">https://bugs.openjdk.java.net/browse/JDK-8142483</a><br>
  </blockquote>
    <br>
    Looks good.<br>
    <br>
    Bengt<br>
    <br>
    <blockquote cite="mid:5645AB4F.40907@oracle.com" type="cite"> <br>
      Thanks,<br>
      Marcus<br>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic