[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: 8133245 Use external.lib.roots instead of relative paths for @library
From: Staffan Larsen <staffan.larsen () oracle ! com>
Date: 2015-08-10 12:44:11
Message-ID: 2A936754-9616-4B18-BC9D-8C6D9AFC534B () oracle ! com
[Download RAW message or body]
> On 10 aug 2015, at 14:33, Jaroslav Bachorik <jaroslav.bachorik@oracle.com> wrote:
>
> On 10.8.2015 05:19, Staffan Larsen wrote:
> >
> > > On 10 aug 2015, at 14:03, Jaroslav Bachorik
> > > <jaroslav.bachorik@oracle.com <mailto:jaroslav.bachorik@oracle.com> \
> > > <mailto:jaroslav.bachorik@oracle.com <mailto:jaroslav.bachorik@oracle.com>>> \
> > > wrote:
> > > Hi Staffan,
> > >
> > > On 10.8.2015 01:19, Staffan Larsen wrote:
> > > > jtreg @library entries like these:
> > > >
> > > > @library /../../test/lib
> > > >
> > > > which refer to classes in the top-level repo, can be changed to
> > > >
> > > > * @library /test/lib
> > > >
> > > > if external.lib.roots=../../ is added to TEST.ROOT. This is a new
> > > > feature in jtreg 4.1b12 (which we are currently using).
> > > >
> > > > Please review the changes to the serviceability tests to incorporate
> > > > this:
> > > >
> > > > bug: https://bugs.openjdk.java.net/browse/JDK-8133245
> > > > webrev hotspot:
> > > > http://cr.openjdk.java.net/~sla/8133245/hotspot/webrev.00/
> > >
> > > Looks good.
> > >
> > > > webrev jdk:http://cr.openjdk.java.net/~sla/8133245/jdk/webrev.00/
> > >
> > > test/TEST.ROOT - shouldn't there be '4.1 b12' instead of '4.1 b11’?
> >
> > Yes, it does say ‘4.1 b12’:
> > http://cr.openjdk.java.net/~sla/8133245/jdk/webrev.00/test/TEST.ROOT.udiff.html
>
> I completely missed it :(
>
> In that case - ship it!
Thanks!
>
> -JB-
>
> >
> > /Staffan
> >
> > >
> > > Otherwise looks good too.
> > >
> > > -JB-
> > >
> > > >
> > > > Thanks,
> > > > /Staffan
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote \
type="cite" class=""><div class="">On 10 aug 2015, at 14:33, Jaroslav Bachorik <<a \
href="mailto:jaroslav.bachorik@oracle.com" \
class="">jaroslav.bachorik@oracle.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; \
font-size: 16px; font-style: normal; font-variant: normal; font-weight: normal; \
letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; \
text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline \
!important;" class="">On 10.8.2015 05:19, Staffan Larsen wrote:</span><br \
style="font-family: Helvetica; font-size: 16px; font-style: normal; font-variant: \
normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" \
class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 16px; \
font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: \
normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; \
-webkit-text-stroke-width: 0px;" class=""><br class=""><blockquote type="cite" \
class="">On 10 aug 2015, at 14:03, Jaroslav Bachorik<br class=""><<a \
href="mailto:jaroslav.bachorik@oracle.com" \
class="">jaroslav.bachorik@oracle.com</a><span \
class="Apple-converted-space"> </span><<a \
href="mailto:jaroslav.bachorik@oracle.com" \
class="">mailto:jaroslav.bachorik@oracle.com</a>>><br class="">wrote:<br \
class=""><br class="">Hi Staffan,<br class=""><br class="">On 10.8.2015 01:19, \
Staffan Larsen wrote:<br class=""><blockquote type="cite" class="">jtreg @library \
entries like these:<br class=""><br class="">@library /../../test/lib<br class=""><br \
class="">which refer to classes in the top-level repo, can be changed to<br \
class=""><br class=""> * @library /test/lib<br class=""><br class="">if \
external.lib.roots=../../ is added to TEST.ROOT. This is a new<br class="">feature in \
jtreg 4.1b12 (which we are currently using).<br class=""><br class="">Please review \
the changes to the serviceability tests to incorporate<br class="">this:<br \
class=""><br class="">bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8133245" \
class="">https://bugs.openjdk.java.net/browse/JDK-8133245</a><br class="">webrev \
hotspot:<br class=""><a \
href="http://cr.openjdk.java.net/~sla/8133245/hotspot/webrev.00/" \
class="">http://cr.openjdk.java.net/~sla/8133245/hotspot/webrev.00/</a><br \
class=""></blockquote><br class="">Looks good.<br class=""><br class=""><blockquote \
type="cite" class="">webrev jdk:http://<a \
href="http://cr.openjdk.java.net/~sla/8133245/jdk/webrev.00/" \
class="">cr.openjdk.java.net/~sla/8133245/jdk/webrev.00/</a><br \
class=""></blockquote><br class="">test/TEST.ROOT - shouldn't there be '4.1 b12' \
instead of '4.1 b11’?<br class=""></blockquote><br class="">Yes, it does say ‘4.1 \
b12’:<br class=""><a \
href="http://cr.openjdk.java.net/~sla/8133245/jdk/webrev.00/test/TEST.ROOT.udiff.html" \
class="">http://cr.openjdk.java.net/~sla/8133245/jdk/webrev.00/test/TEST.ROOT.udiff.html</a><br \
class=""></blockquote><br style="font-family: Helvetica; font-size: 16px; font-style: \
normal; font-variant: normal; font-weight: normal; letter-spacing: normal; \
line-height: normal; orphans: auto; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; \
-webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; \
font-size: 16px; font-style: normal; font-variant: normal; font-weight: normal; \
letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; \
text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline \
!important;" class="">I completely missed it :(</span><br style="font-family: \
Helvetica; font-size: 16px; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: \
Helvetica; font-size: 16px; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span \
style="font-family: Helvetica; font-size: 16px; font-style: normal; font-variant: \
normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; \
display: inline !important;" class="">In that case - ship it!</span><br \
style="font-family: Helvetica; font-size: 16px; font-style: normal; font-variant: \
normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" \
class=""></div></blockquote><div><br class=""></div>Thanks!</div><div><br \
class=""><blockquote type="cite" class=""><div class=""><br style="font-family: \
Helvetica; font-size: 16px; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span \
style="font-family: Helvetica; font-size: 16px; font-style: normal; font-variant: \
normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; \
display: inline !important;" class="">-JB-</span><br style="font-family: Helvetica; \
font-size: 16px; font-style: normal; font-variant: normal; font-weight: normal; \
letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; \
text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: \
Helvetica; font-size: 16px; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" \
style="font-family: Helvetica; font-size: 16px; font-style: normal; font-variant: \
normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br \
class="">/Staffan<br class=""><br class=""><blockquote type="cite" class=""><br \
class="">Otherwise looks good too.<br class=""><br class="">-JB-<br class=""><br \
class=""><blockquote type="cite" class=""><br class="">Thanks,<br \
class="">/Staffan</blockquote></blockquote></blockquote></div></blockquote></div><br \
class=""></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic