[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S) 8080401: Uninitialised variable in hotspot/src/os/solaris/dtrace/
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2015-08-07 13:53:21
Message-ID: 55C4B851.1040908 () oracle ! com
[Download RAW message or body]

On 8/7/15 06:45, Dmitry Samersoff wrote:
> Serguei,
>
> Looks good for me.

Thanks a lot!

>
> It might be better to use (uint64_t) -1 for initialization of pc_diff in
> libjvm_db.c

Thank you for the suggestion.
It'd work but not that important. :)


Thanks,
Serguei

>      
> -Dmitry
>
> On 2015-08-07 13:25, serguei.spitsyn@oracle.com wrote:
>> Please, review the jdk 9 fix for:
>>    https://bugs.openjdk.java.net/browse/JDK-8080401
>>
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8080401-dtrace-parfait2.1/
>>
>>
>>
>> Summary:
>>
>>    The fix includes the parfait issues listed in the bug report.
>>
>>
>> Testing:
>>    The JPRT build
>>
>>
>> Thanks,
>> Serguei
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 8/7/15 06:45, Dmitry Samersoff
      wrote:<br>
    </div>
    <blockquote cite="mid:55C4B68D.6040501@oracle.com" type="cite">
      <pre wrap="">Serguei,

Looks good for me.</pre>
    </blockquote>
    <br>
    <small>Thanks a lot!</small><br>
    <br>
    <blockquote cite="mid:55C4B68D.6040501@oracle.com" type="cite">
      <pre wrap="">

It might be better to use (uint64_t) -1 for initialization of pc_diff in
libjvm_db.c</pre>
    </blockquote>
    <br>
    <small>Thank you for the suggestion.<br>
      It'd work but not that important. :)<br>
      <br>
      <br>
      Thanks,<br>
      Serguei<br>
    </small><br>
    <blockquote cite="mid:55C4B68D.6040501@oracle.com" type="cite">
      <pre wrap="">
    
-Dmitry

On 2015-08-07 13:25, <a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote: </pre>
      <blockquote type="cite">
        <pre wrap="">
Please, review the jdk 9 fix for:
  <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8080401">https://bugs.openjdk.java.net/browse/JDK-8080401</a>



Open webrev:
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8080401-dtrace-parfait \
2.1/">http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8080401-dtrace-parfait2.1/</a>




Summary:

  The fix includes the parfait issues listed in the bug report.


Testing:
  The JPRT build


Thanks,
Serguei
</pre>
      </blockquote>
      <pre wrap="">

</pre>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic