[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8131784 : Add tracing info to LowMemoryTest.java to help 8130339 diagnosis
From:       Jaroslav Bachorik <jaroslav.bachorik () oracle ! com>
Date:       2015-07-31 17:10:07
Message-ID: 55BBABEF.2080900 () oracle ! com
[Download RAW message or body]

Good to go!

-JB-

On 31.7.2015 18:44, olivier.lagneau@oracle.com wrote:
> Thanks Jaroslav and Serguey for the comments for first pass of review.
>
> I have fixed the patch following your comments.
>
> Please find the 2nd version here :
> webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.01/
>
> Thanks,
> Olivier.
>
> On 30/07/2015 18:55, olivier.lagneau@oracle.com wrote:
>> Hi,
>>
>> Could you please review this fix:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8131784
>> webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.00/
>>
>> We add tracing information to help diagnosing master bug problem
>> (https://bugs.openjdk.java.net/browse/JDK-8130339),
>> and we will monitor the quarantined runs to check for any failure and
>> get more diagnosis info.
>>
>> Since the test already provides some information which is not
>> collected when it fails with timeout,
>> the idea is to collect subprocess I/O (stdout, stderr) by using
>> ProcessTools.startProcess rather
>> that OutputAnalyzer.executeProcess. The subprocess I/Os will be
>> collected while it's running
>> rather than waiting the subprocess termination.
>>
>> A few additional infos have also been added to get more information.
>>
>> Note that this "tracing" change should be temporary and will be
>> removed when a fix for 8130339 has been found.
>>
>> Thanks,
>> Olivier.
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]