[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (XS): 6661889: thread id on Linux is inconsistent in error and log outputs
From:       Jeremy Manson <jeremymanson () google ! com>
Date:       2015-07-30 5:48:28
Message-ID: CAPYFHW2EjfWPBRLLxvDn=G-+qMDJcoZqHH1_wPUaz8jvse-1Pg () mail ! gmail ! com
[Download RAW message or body]

Thanks, folks!

Jeremy

On Wed, Jul 29, 2015 at 8:03 PM, David Holmes <david.holmes@oracle.com>
wrote:

> On 30/07/2015 9:07 AM, Vladimir Kozlov wrote:
>
>> Finally after 7 years, since I filed this bug, it will be fixed :)
>>
>
> I hope it now does what you wanted :)
>
> On its way.
>
> Thanks,
> David
>
>
>  Looks good.
>>
>> Thanks,
>> Vladimir
>>
>> On 7/29/15 3:31 PM, David Holmes wrote:
>>
>>> Hi Jeremy,
>>>
>>> On 30/07/2015 6:34 AM, Jeremy Manson wrote:
>>>
>>>> David, can you review/sponsor this, per our conversation of last week?
>>>>
>>>
>>> Yes I can sponsor and it is also Reviewed.
>>>
>>> But I'd like a second review from someone else.
>>>
>>> Thanks,
>>> David
>>>
>>>  It fixes an issue where, on Linux, some of the Hotspot logging output
>>>> identifies threads by pthread_id, and some of it identifies threads by
>>>> kernel-level TID.  This happened because Hotspot calls into two
>>>> different APIs that provide the thread ID, and developers seem to have
>>>> picked which one they call at random.
>>>>
>>>> The CR makes these APIs consistently use the kernel-level TID, and makes
>>>> one of the APIs a thin shim over the other.
>>>>
>>>> Conversation:
>>>>
>>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-July/015507.html
>>>>
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6661889
>>>> Webrev: http://cr.openjdk.java.net/~jmanson/6661889/webrev.01/
>>>>
>>>> Jeremy
>>>>
>>>

[Attachment #3 (text/html)]

<div dir="ltr">Thanks, folks!<div><br></div><div>Jeremy</div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 29, 2015 at 8:03 PM, \
David Holmes <span dir="ltr">&lt;<a href="mailto:david.holmes@oracle.com" \
target="_blank">david.holmes@oracle.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span class="">On 30/07/2015 9:07 AM, Vladimir Kozlov \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> Finally after 7 years, since I filed this bug, it will \
be fixed :)<br> </blockquote>
<br></span>
I hope it now does what you wanted :)<br>
<br>
On its way.<br>
<br>
Thanks,<br>
David<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Looks good.<br>
<br>
Thanks,<br>
Vladimir<br>
<br>
On 7/29/15 3:31 PM, David Holmes wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi Jeremy,<br>
<br>
On 30/07/2015 6:34 AM, Jeremy Manson wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> David, can you review/sponsor this, per our conversation of \
last week?<br> </blockquote>
<br>
Yes I can sponsor and it is also Reviewed.<br>
<br>
But I&#39;d like a second review from someone else.<br>
<br>
Thanks,<br>
David<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> It fixes an issue where, on Linux, some of the Hotspot \
logging output<br> identifies threads by pthread_id, and some of it identifies \
threads by<br> kernel-level TID.   This happened because Hotspot calls into two<br>
different APIs that provide the thread ID, and developers seem to have<br>
picked which one they call at random.<br>
<br>
The CR makes these APIs consistently use the kernel-level TID, and makes<br>
one of the APIs a thin shim over the other.<br>
<br>
Conversation:<br>
<a href="http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-July/015507.html" \
rel="noreferrer" target="_blank">http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-July/015507.html</a><br>
 <br>
<br>
Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-6661889" rel="noreferrer" \
                target="_blank">https://bugs.openjdk.java.net/browse/JDK-6661889</a><br>
                
Webrev: <a href="http://cr.openjdk.java.net/~jmanson/6661889/webrev.01/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~jmanson/6661889/webrev.01/</a><br>
 <br>
Jeremy<br>
</blockquote></blockquote></blockquote>
</div></div></blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]