[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR(XS): 8076471: Remove hprof agent tests in JDK
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2015-07-15 10:12:47
Message-ID: 55A6321F.8010402 () oracle ! com
[Download RAW message or body]
Ok, thanks!
Serguei
On 7/15/15 3:07 AM, Yekaterina Kantserova wrote:
> Hi Serguei,
>
> Thanks a lot for looking at it! Yes, I unintentionally removed
> test/demo/jvmti instead of test/demo/jvmti/hprof :( Will restore the
> tests asap.
>
> // Katja
>
>
>
> On 07/15/2015 11:58 AM, serguei.spitsyn@oracle.com wrote:
> > Hi Katya,
> >
> >
> > On 7/15/15 2:22 AM, Yekaterina Kantserova wrote:
> > > Hi,
> > >
> > > I've forgotten to remove serviceability/hprof/cpu002.java test in
> > > hotspot repo. Could I please have a review for this change?
> > >
> > > webrev: http://cr.openjdk.java.net/~ykantser/8076471.hotspot/webrev.00
> >
> > This looks good.
> >
> > >
> > > Thanks,
> > > Katja
> > >
> > >
> > >
> > > On 07/10/2015 02:55 PM, Yekaterina Kantserova wrote:
> > > > Hi,
> > > >
> > > > Could I please have a review of this fix.
> > > >
> > > > bug: https://bugs.openjdk.java.net/browse/JDK-8076471
> > > > webrev: http://cr.openjdk.java.net/~ykantser/8076471/webrev.00
> >
> > It looks good but I'm not sure why have you deleted these tests as well:
> >
> > > ------ ------ ------ ------ Old
> > <http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/minst/MinstExample.java-.html> \
> >
> > --- ----- --- | *test/demo/jvmti/minst/MinstExample.java*
> >
> > > ------ ------ ------ ------ Old
> > <http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/minst/MinstTest.java-.html> \
> >
> > --- ----- --- | *test/demo/jvmti/minst/MinstTest.java*
> >
> > > ------ ------ ------ ------ Old
> > <http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/versionCheck/FailsWhenJvmtiVersionDiffers.java-.html> \
> >
> > --- ----- --- |
> > *test/demo/jvmti/versionCheck/FailsWhenJvmtiVersionDiffers.java*
> >
> > > ------ ------ ------ ------ Old
> > <http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/waiters/WaitersTest.java-.html> \
> >
> > --- ----- --- | *test/demo/jvmti/waiters/WaitersTest.java*
> >
> >
> > Did you want to remove all the demo tests, not hprof only?
> > Just want to make sure you did not get rid of them unintentionally.
> >
> >
> > Thanks,
> > Serguei
> >
> >
> > > >
> > > > More details can be found in JEP 240: Remove the JVM TI hprof Agent
> > > > (https://bugs.openjdk.java.net/browse/JDK-8046661).
> > > >
> > > > Thanks,
> > > > Katja
> > >
> >
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Ok, thanks!<br>
Serguei<br>
<br>
<br>
On 7/15/15 3:07 AM, Yekaterina Kantserova wrote:<br>
</div>
<blockquote cite="mid:55A630E0.7010009@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Serguei,<br>
<br>
Thanks a lot for looking at it! Yes, I unintentionally removed
test/demo/jvmti instead of test/demo/jvmti/hprof :( Will restore
the tests asap.<br>
<br>
// Katja<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 07/15/2015 11:58 AM, <a
moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>
wrote:<br>
</div>
<blockquote cite="mid:55A62EC6.5030100@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Katya,<br>
<br>
<br>
On 7/15/15 2:22 AM, Yekaterina Kantserova wrote:<br>
</div>
<blockquote cite="mid:55A6266C.5030804@oracle.com" type="cite">Hi,
<br>
<br>
I've forgotten to remove serviceability/hprof/cpu002.java test
in hotspot repo. Could I please have a review for this change?
<br>
<br>
webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eykantser/8076471.hotspot/webrev.00">http://cr.openjdk.java.net/~ykantser/8076471.hotspot/webrev.00</a>
<br>
</blockquote>
<br>
This looks good.<br>
<br>
<blockquote cite="mid:55A6266C.5030804@oracle.com" type="cite">
<br>
Thanks, <br>
Katja <br>
<br>
<br>
<br>
On 07/10/2015 02:55 PM, Yekaterina Kantserova wrote: <br>
<blockquote type="cite">Hi, <br>
<br>
Could I please have a review of this fix. <br>
<br>
bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8076471">https://bugs.openjdk.java.net/browse/JDK-8076471</a>
<br>
webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00">http://cr.openjdk.java.net/~ykantser/8076471/webrev.00</a>
<br>
</blockquote>
</blockquote>
<br>
It looks good but I'm not sure why have you deleted these tests
as well:<br>
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<p><code> ------ ------ ------ ------ <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/minst/MinstExample.java-.html">Old</a>
--- ----- --- </code> <font \
color="red"><b>test/demo/jvmti/minst/MinstExample.java</b></font></p> <p><code> \
------ ------ ------ ------ <a moz-do-not-send="true" \
href="http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/minst/MinstTest.java-.html">Old</a>
--- ----- --- </code> <font \
color="red"><b>test/demo/jvmti/minst/MinstTest.java</b></font> </p>
<p><code> ------ ------ ------ ------ <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/versionCheck/FailsWhenJvmtiVersionDiffers.java-.html">Old</a>
--- ----- --- </code> <font \
color="red"><b>test/demo/jvmti/versionCheck/FailsWhenJvmtiVersionDiffers.java</b></font>
</p>
<p><code> ------ ------ ------ ------ <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eykantser/8076471/webrev.00/test/demo/jvmti/waiters/WaitersTest.java-.html">Old</a>
--- ----- --- </code> <font \
color="red"><b>test/demo/jvmti/waiters/WaitersTest.java</b></font> </p>
<br>
Did you want to remove all the demo tests, not hprof only?<br>
Just want to make sure you did not get rid of them
unintentionally.<br>
<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<blockquote cite="mid:55A6266C.5030804@oracle.com" type="cite">
<blockquote type="cite"> <br>
More details can be found in JEP 240: Remove the JVM TI
hprof Agent (<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8046661">https://bugs.openjdk.java.net/browse/JDK-8046661</a>).
<br>
<br>
Thanks, <br>
Katja <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic