[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [RFR] (XS) 8129386: [TESTBUG] - com/sun/jdi/cds/*.java missing @build tag for libraries
From:       Chris Plummer <chris.plummer () oracle ! com>
Date:       2015-06-23 4:21:19
Message-ID: 5588DEBF.5090501 () oracle ! com
[Download RAW message or body]

Thanks Misha!

And also thank you to Ioi for the review.

Chris

On 6/22/15 7:14 PM, Mikhailo Seledtsov wrote:
> Hi Chris,
>
> After discussion and better understanding the problem, I agree with 
> the changes.
> I have also added a new comment to the issue.
>
> Misha
>
> On 6/22/2015 4:14 PM, Mikhailo Seledtsov wrote:
>> Hi Chris,
>>
>>  Please see my comments in the original issue, (Mikhailo Seledtsov 
>> <https://bugs.openjdk.java.net/secure/ViewProfile.jspa?name=mseledtsov> 
>> added a comment - 2015-06-22 19:12).
>>
>> Misha
>>
>> On 6/22/2015 2:27 PM, Ioi Lam wrote:
>>> Looks good to me, but someone from SQE should revew this.
>>>
>>> Thanks
>>> - Ioi
>>>
>>> On 6/22/15 1:57 PM, Chris Plummer wrote:
>>>> Please review the following fix for 8129386:
>>>>
>>>> http://cr.openjdk.java.net/~cjplummer/8129386/webrev.00/webrev.jdk/
>>>> https://bugs.openjdk.java.net/browse/JDK-8129386
>>>>
>>>> thanks,
>>>>
>>>> Chris
>>>>
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]