[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR 8081634: Concurrent usage of a StringBuilder causes test intermittent failures
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2015-06-18 11:10:14
Message-ID: 5582A716.70003 () oracle ! com
[Download RAW message or body]

Looks good.

Thanks,
Serguei


On 6/17/15 11:54 AM, Jaroslav Bachorik wrote:
> Please, review the following test change
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8081634
> Webrev: http://cr.openjdk.java.net/~jbachorik/8081634/webrev.00
>
> This is an issue in the utility class providing the functionality to 
> run the 'jcmd' command and parse its output. The jcmd command output 
> is being captured in a separate thread and fed to a shared 
> StringBuilder instance. StringBuilder not being synchronized this 
> might lead to intermittent failures due to (mostly) the write 
> visibility. The fix is to use StringBuffer which is the appropriate 
> class for this kind of usage.
>
> Thanks,
>
> -JB-

[prev in list] [next in list] [prev in thread] [next in thread]