[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8081475: SystemTap does not work when JDK is compiled with GCC 5
From:       David Holmes <david.holmes () oracle ! com>
Date:       2015-05-29 10:04:46
Message-ID: 556839BE.902 () oracle ! com
[Download RAW message or body]

Hi Yasumasa,

Fix looks good to me. I think someone had tried to handle this but
simply got it wrong as the check would pass for 4.4+ and 5+.4+ :(

I noone else jumps in on a local Friday I can sponsor this on my Monday.

Cheers,
David

On 29/05/2015 7:38 PM, Yasumasa Suenaga wrote:
> Hi all,
> 
> I tried to build jdk9/hs-rt on Fedora 22 with GCC 5.1.1 .
> However, libjvm.so did not have .note.stapsdt section.
> 
> When I ran make command with LOG=info, I found a message as below:
> ---------------
> **NOTICE** Dtrace support disabled: gcc version is too old
> ---------------
> 
> hotspot/make/linux/makefiles/dtrace.make checks C compiler version.
> However, its condition cannot check 5.x or later.
> 
> So I fix the condition. Could you review it?
>     http://cr.openjdk.java.net/~ysuenaga/JDK-8081475/webrev.00/
> 
> This patch works fine on my environment.
> This issue is occurred on 8u-dev. So I also want to fix it for 8u-dev.
> 
> 
> I'm jdk9 committer, but I'm not employee at Oracle.
> So I need a Sponsor.
> 
> 
> Thanks,
> 
> Yasumasa
> 
[prev in list] [next in list] [prev in thread] [next in thread]