[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: PING Re: RFR: 8078521: AARCH64: Add AArch64 SA support
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2015-05-19 16:49:07
Message-ID: 555B6983.30000 () oracle ! com
[Download RAW message or body]

Andrew,

Looks good for me. (not a Reviewer)

> This will now enable the code for PPC; I guess that's OK.

I think so too.

-Dmitry


On 2015-05-19 18:20, Andrew Haley wrote:
> On 05/16/2015 06:03 PM, Dmitry Samersoff wrote:
>> Andrew,
>>
>> On 2015-05-12 20:05, Andrew Haley wrote:
>>> http://cr.openjdk.java.net/~aph/8078521-4/
>>
>> HSDB.java:
>>
>> 988: If you removed else part, you don't need to check CPU here at all,
>>      just leave a comment.
> 
> This will now enable the code for PPC; I guess that's OK.
> 
>> LinuxAARCH64CFrame.java:
>>
>> 65 - it's better to add brackets around 2 * ADDRESS_SIZE
>> 69,73  - please, remove space after bracket.
> 
> Done.
> 
> http://cr.openjdk.java.net/~aph/8078521-5/
> 
> Thanks,
> Andrew.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
[prev in list] [next in list] [prev in thread] [next in thread]