[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR 8072906: sun/management/jmxremote/bootstrap/CustomLauncherTest.java
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2015-04-30 22:20:53
Message-ID: 5542AAC5.1040906 () oracle ! com
[Download RAW message or body]

+1 for the suggestion from David.
Otherwise, the fix looks Ok.
No need to re-review after printing a message is added.

Thanks,
Serguei

On 4/30/15 2:08 PM, David Holmes wrote:
> On 1/05/2015 12:48 AM, Jaroslav Bachorik wrote:
>> Please, review the following test change
>>
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8072906
>> Webrev: http://cr.openjdk.java.net/~jbachorik/8072906/webrev.00
>>
>> The test tries to exercise a custom launcher on embedded platforms and
>> fails because the corresponding binary is not available. The test should
>> not require the presence of the binary and skip the execution gracefully
>> if it can't find one - this was broken while addressing JDK-8029809.
>>
>> The fix brings back the ability just skip the test if the launcher
>> binary does not exist.
>
> A message to that effect would be useful.
>
> Thanks,
> David
>
>> Thanks,
>>
>> -JB-

[prev in list] [next in list] [prev in thread] [next in thread]