[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR 8077402: JMXStartStopTest fails intermittently on slow hosts
From:       David Holmes <david.holmes () oracle ! com>
Date:       2015-04-27 0:26:18
Message-ID: 553D822A.6090303 () oracle ! com
[Download RAW message or body]

Looks okay.

Thanks,
David

On 24/04/2015 9:28 PM, Jaroslav Bachorik wrote:
> Please, review the following test change
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8077402
> Webrev: http://cr.openjdk.java.net/~jbachorik/8077402/webrev.00
>
> Currently, the test waits for 5*{timeout.factor} seconds for the target
> application to start up before timing out. On extremely slow machines
> even the timeout.factor will not assure a successful target application
> startup and the test will fail sporadically.
>
> The proposed solution is to defer timing-out to the test harness. The
> test library will still take care of collecting the thread dump and
> terminating any left-over processes (ProcessTools.startProcess()
> methods). While this will not remedy the failures on extremely slow
> machines it is better not to introduce any additional arbitrary time-out
> limits.
>
> As a part of this patch there is a small clarification in the javadoc of
> ProcessTools.startProcess() method and a null check in
> JMXStartStopTest$TestAppRun to prevent NPE hiding the timeout message.
>
> Thanks,
>
> -JB-
[prev in list] [next in list] [prev in thread] [next in thread]