[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8077423: jstatd is not terminated even though it cannot contact or bind to RMI Registry
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2015-04-15 14:55:21
Message-ID: 87312687-D97E-4306-880B-CD395D565064 () oracle ! com
[Download RAW message or body]

Looks good!

Thanks,
/Staffan


> On 15 apr 2015, at 16:46, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> \
> wrote: 
> Hi,
> 
> Could I please have a review of this fix.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8077423
> webrev: http://cr.openjdk.java.net/~ykantser/8077423/webrev.00/
> 
> A couple of comments about changes in sun/tools/jstatd/JstatdTest.java. If the \
> suggested fix will be accepted there will be no need of waitForJstatdRMI(), because \
> jstad will either be started properly or will terminate. 
> A check has been added that there is no RMi Registry already running on default \
> port. Otherwise the test will fail fast. 
> A sanity check for "-nr" option has been added as well.
> 
> http://docs.oracle.com/javase/7/docs/technotes/tools/share/jstatd.html
> "-nr
> Do not attempt to create an internal RMI registry within the jstatd process when an \
> existing RMI registry is not found." 
> 
> Thanks,
> Katja


[prev in list] [next in list] [prev in thread] [next in thread]