[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8075056 Remove Version.java.template from jconsole
From:       Erik Gahlin <erik.gahlin () oracle ! com>
Date:       2015-03-12 20:53:23
Message-ID: 5501FCC3.3010905 () oracle ! com
[Download RAW message or body]

Looks good, jconsole now compile in Eclipse!

Erik

Staffan Larsen skrev 2015-03-12 13:54:
> The build for jconsole currently takes a template file and inserts the 
> version number of the build into the file. We can simplify this by 
> removing the template file and reading the java.runtime.version system 
> property at runtime.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8075056
> webrev: http://cr.openjdk.java.net/~sla/8075056/webrev.00/ 
> <http://cr.openjdk.java.net/%7Esla/8075056/webrev.00/>
>
> Thanks,
> /Staffan


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Looks good, jconsole now compile in
      Eclipse!<br>
      <br>
      Erik<br>
      <br>
      Staffan Larsen skrev 2015-03-12 13:54:<br>
    </div>
    <blockquote
      cite="mid:49906944-9257-4233-83D9-5595758FA2DE@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=ISO-8859-1">
      <div class="">The build for jconsole currently takes a template
        file and inserts the version number of the build into the file.
        We can simplify this by removing the template file and&nbsp;reading
        the java.runtime.version system property at runtime.</div>
      <div class=""><br class="">
      </div>
      bug:&nbsp;<a moz-do-not-send="true"
        href="https://bugs.openjdk.java.net/browse/JDK-8075056" \
class="">https://bugs.openjdk.java.net/browse/JDK-8075056</a>  <div class="">webrev: \
<a moz-do-not-send="true"  \
                href="http://cr.openjdk.java.net/%7Esla/8075056/webrev.00/"
          class="">http://cr.openjdk.java.net/~sla/8075056/webrev.00/</a></div>
      <div class=""><br class="">
      </div>
      <div class="">
        <div class="">Thanks,</div>
        <div class="">/Staffan</div>
      </div>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic