[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: 6588467: Add isDaemon() and getPriority() to ThreadInfo
From: Staffan Larsen <staffan.larsen () oracle ! com>
Date: 2015-02-24 7:40:22
Message-ID: 75FE522E-4E33-4705-A849-7291A2BB3130 () oracle ! com
[Download RAW message or body]
I can push this for you.
Thanks!
/Staffan
> On 24 feb 2015, at 05:58, Jeremy Manson <jeremymanson@google.com> wrote:
>
> Thanks, Mandy.
>
> I guess it is time to submit. I don't have a committer bit. Any volunteers?
>
> Thanks to all for the review!
>
> Jeremy
>
> On Mon, Feb 23, 2015 at 5:29 PM, Mandy Chung <mandy.chung@oracle.com \
> <mailto:mandy.chung@oracle.com>> wrote: On 2/23/15 11:49 AM, Jeremy Manson wrote:
> Okey-doke:
>
> http://cr.openjdk.java.net/~jmanson/6588467/webrev.03/ \
> <http://cr.openjdk.java.net/~jmanson/6588467/webrev.03/> \
> <http://cr.openjdk.java.net/%7Ejmanson/6588467/webrev.03/ \
> <http://cr.openjdk.java.net/%7Ejmanson/6588467/webrev.03/>>
>
> Looks good. Minor comment: @see Thread#isDaemon can be removed since you have it \
> in @linkplain. No need for a new webrev.
> Thanks.
> Mandy
>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;" class="">I can push this for you.<div \
class=""><br class=""></div><div class="">Thanks!</div><div class=""><br \
class=""></div><div class="">/Staffan</div><div class=""><br \
class=""><div><blockquote type="cite" class=""><div class="">On 24 feb 2015, at \
05:58, Jeremy Manson <<a href="mailto:jeremymanson@google.com" \
class="">jeremymanson@google.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Thanks, \
Mandy.<div class=""><br class=""></div><div class="">I guess it is time to \
submit. I don't have a committer bit. Any volunteers?</div><div \
class=""><br class=""></div><div class="">Thanks to all for the review!</div><div \
class=""><br class=""></div><div class="">Jeremy</div></div><div \
class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Feb 23, 2015 at \
5:29 PM, Mandy Chung <span dir="ltr" class=""><<a \
href="mailto:mandy.chung@oracle.com" target="_blank" \
class="">mandy.chung@oracle.com</a>></span> wrote:<br class=""><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">On 2/23/15 11:49 AM, Jeremy Manson wrote:<br class=""> \
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Okey-doke:<br class="">
<br class="">
<a href="http://cr.openjdk.java.net/~jmanson/6588467/webrev.03/" target="_blank" \
class="">http://cr.openjdk.java.net/~<u class=""></u>jmanson/6588467/webrev.03/</a> \
<<a href="http://cr.openjdk.java.net/%7Ejmanson/6588467/webrev.03/" \
target="_blank" class="">http://cr.openjdk.java.net/%<u \
class=""></u>7Ejmanson/6588467/webrev.03/</a>><br class=""> <br class="">
</blockquote>
<br class="">
Looks good. Minor comment: @see Thread#isDaemon can be removed since you \
have it in @linkplain. No need for a new webrev.<br class=""> <br class="">
Thanks.<span class="HOEnZb"><font color="#888888" class=""><br class="">
Mandy<br class="">
</font></span></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic