[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy
From: Chris Plummer <chris.plummer () oracle ! com>
Date: 2015-02-13 19:49:41
Message-ID: 54DE5555.3010701 () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Thanks Staffan! And I really appreciate
all your reviews. Also thanks to Mikael for the DCMD test review.<br>
<br>
Cheers,<br>
<br>
Chris<br>
<br>
On 2/12/15 1:19 AM, Staffan Larsen wrote:<br>
</div>
<blockquote
cite="mid:776B0873-7B7B-4537-B620-B32056723777@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="">Looks good! </div>
<div class=""><br class="">
</div>
<div class="">Thanks for providing incremental webrevs - very
helpful!</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">/Staffan</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div>
<blockquote type="cite" class="">
<div class="">On 12 feb 2015, at 09:31, Chris Plummer <<a
moz-do-not-send="true"
href="mailto:chris.plummer@oracle.com" \
class="">chris.plummer@oracle.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
<div class="moz-cite-prefix">I suppose it would be nice if
I included links to the webrevs:<br class="">
<br class="">
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ecjplummer/8054888/webrev.02-03/">http://cr.openjdk.java.net/~cjplummer/8054888/webrev.02-03/</a><br
class="">
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ecjplummer/8054888/webrev.03/">http://cr.openjdk.java.net/~cjplummer/8054888/webrev.03/</a><br
class="">
<br class="">
First one is just the latest changes described in the
previous email. 2nd one includes all changes.<br
class="">
<br class="">
thanks,<br class="">
<br class="">
Chris<br class="">
<br class="">
On 2/12/15 12:28 AM, Chris Plummer wrote:<br class="">
</div>
<blockquote cite="mid:54DC6424.9050109@oracle.com"
type="cite" class="">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type" class="">
<div class="moz-cite-prefix">Ok, hopefully the last
webrev. :)<br class="">
<br class="">
-JPRT found a compiler error on Solaris.
<meta http-equiv="content-type" content="text/html;
charset=utf-8" class="">
classfile/systemDictionary.hpp needed to be included
due to the reference to
<meta http-equiv="content-type" content="text/html;
charset=utf-8" class="">
SystemDictionary::Object_klass(). I assume this turned
up on Solaris because it doesn't use precompiled
headers.<br class="">
<br class="">
-I noticed I had inadvertently removed a ResourceMark
in KlassInfoHisto::print_class_stats(). I think maybe
I had done a cut-n-paste rather than copy-n-paste.
This was in webrev.01 but was pretty inconspicuous in
the webrev so went noticed.<br class="">
<br class="">
-I changed another WARNING to ERROR as Staffan
requested.<br class="">
<br class="">
-I updated to the latest JDK9 sources and made the
needed changes to the DCMD test as Mikael requested.<br
class="">
<br class="">
thanks,<br class="">
<br class="">
Chris<br class="">
<br class="">
On 2/11/15 9:38 AM, Chris Plummer wrote:<br class="">
</div>
<blockquote cite="mid:54DB938A.7000002@oracle.com"
type="cite" class="">On 2/11/15 2:12 AM, Mikael Auno
wrote: <br class="">
<blockquote type="cite" class="">On 2015-02-11 04:13,
Chris Plummer wrote: <br class="">
<blockquote type="cite" class="">
<blockquote type="cite" class="">In general I
think this looks very good. Simple and
well-commented <br class="">
code to follow. I am missing a test, though.
Please look at the <br class="">
hotspot/test/serviceability/dcmd set of tests. <br
class="">
</blockquote>
Added. <br class="">
</blockquote>
Your test is based on DcmdUtil.java which was
removed last week (see <br class="">
[0]). If you pull new changes from hs-rt/hotspot,
you'll see plenty of <br class="">
tests using the new DCMD utility classes in
testlibrary. Also, the new <br class="">
tests are divided in different subdirectories
depending on the commands, <br class="">
so as your test exercises VM.class_hierarchy it
should go in <br class="">
.../dcmd/vm/ as opposed to just .../dcmd/. <br
class="">
<br class="">
Thanks, <br class="">
Mikael <br class="">
<br class="">
[0] <br class="">
<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/tip/test/serviceability/dcmd" \
>http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/tip/test/serviceability/dcmd</a> \
> <br class="">
</blockquote>
Ok. I'll pull the latest hs-rt and update the test.
Thanks for pointing that out. <br class="">
<br class="">
Chris <br class="">
</blockquote>
<br class="">
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic