[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8065213 Specify and implement PlatformMBeanProvider for looking for all platform MBeans
From:       Mandy Chung <mandy.chung () oracle ! com>
Date:       2015-01-31 1:19:07
Message-ID: 54CC2D8B.5080507 () oracle ! com
[Download RAW message or body]


On 1/30/2015 9:38 AM, shanliang wrote:
> Thanks for all your comments, here is the new version:
> http://cr.openjdk.java.net/~sjiang/JDK-8065213/01/

Thank you for the update.  Looks fine to me.  Minor comment:

PlatformMBeanProviderImpl.java
   line 43: better to rename it as "list" or other name.
   same as in DefaultPlatformMBeanProvider.java line 54

No need to generate new webrev.

Mandy
[prev in list] [next in list] [prev in thread] [next in thread]