[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8071464: Clear up SVC jdk/test/* JRE layout dependencies other than those on tools.jar
From:       Yekaterina Kantserova <yekaterina.kantserova () oracle ! com>
Date:       2015-01-29 12:35:35
Message-ID: 54CA2917.2030206 () oracle ! com
[Download RAW message or body]

Alex,

I'll push.

// Katja

On 01/29/2015 01:21 PM, Alexander Kulyakhtin wrote:
> Hi Katja, Stafan
> 
> I've corrected the alignment issue, per Stafan's review, and attached the patch.
> 
> Could it be possible to push the patch?
> 
> Thank you very much for your help.
> 
> Best regards,
> Alex
> 
> ----- Original Message -----
> From: staffan.larsen@oracle.com
> To: alexander.kulyakhtin@oracle.com
> Cc: serviceability-dev@openjdk.java.net
> Sent: Thursday, January 29, 2015 11:02:12 AM GMT +04:00 Abu Dhabi / Muscat
> Subject: Re: RFR: JDK-8071464: Clear up SVC jdk/test/* JRE layout dependencies \
> other than those on tools.jar 
> Looks good!
> 
> nit: test/com/sun/jdi/ShellScaffold.sh:947, the alignment for ">&2" got broken.
> 
> Thanks,
> /Staffan
> 
> 
> > On 28 jan 2015, at 17:24, Alexander Kulyakhtin <alexander.kulyakhtin@oracle.com> \
> > wrote: 
> > Hi,
> > 
> > Could you, please, review the fix below.
> > 
> > bug: https://bugs.openjdk.java.net/browse/JDK-8071464
> > webrev: http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8071464/webrev.01/
> > 
> > References to the jre layout are removed from ShellScaffold.sh and DemoRun.java.
> > Other files mentioned in the CR have not been changed as they don't contain any \
> > JRE-related artifacts anymore. 
> > Thanks,
> > Alex


[prev in list] [next in list] [prev in thread] [next in thread]