[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): 8068613: Wrong number of objects pending finalization start
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2015-01-28 12:59:26
Message-ID: F9A17398-D7DA-4FF0-B4FA-4AB64E3BE96B () oracle ! com
[Download RAW message or body]

Sounds good to me.

/Staffan

> On 28 jan 2015, at 13:37, Mattias Tobiasson <mattias.tobiasson@oracle.com> wrote:
> 
> I have tested 200 times on linux, and once on all other platforms (except embedded).
> 
> On 01/28/2015 11:38 AM, Staffan Larsen wrote:
>> Looks good! How much testing have you done?
>> 
>> Thanks,
>> /Staffan
>> 
>>> On 28 jan 2015, at 11:31, Mattias Tobiasson <mattias.tobiasson@oracle.com> wrote:
>>> 
>>> Hi,
>>> Could I please have a review of this test bug fix.
>>> 
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8068613
>>> webrev: http://cr.openjdk.java.net/~ykantser/8068613/webrev.01
>>> 
>>> On line 90 and on line 246 (in the old version) the test does a short wait between
>>> Runtime.getRuntime().runFinalization() and
>>> MemoryMXBean.getObjectPendingFinalizationCount()
>>> 
>>> The test expects getObjectPendingFinalizationCount() to return 0,
>>> but that sometimes fails on really slow servers.
>>> 
>>> The fix will loop until getObjectPendingFinalizationCount() returns 0,
>>> or until it gives up after 100 tries.
>>> 
>>> Thanks,
>>> Mattias
>>> 
> 

[prev in list] [next in list] [prev in thread] [next in thread]