[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8068589: GCCause should distinguish jcmd GC.run from System.gc()
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2015-01-28 8:24:22
Message-ID: 0EC87621-A69D-453E-B0AC-8EB892D3B3CE () oracle ! com
[Download RAW message or body]

Looks good!

Thanks,
/Staffan

> On 28 jan 2015, at 05:48, Yasumasa Suenaga <yasuenag@gmail.com> wrote:
> 
> Hi Staffan, Kirk,
> 
> I agree to set "Diagnostic Command" to GCCause.
> So I applied it to new patch.
> 
> http://cr.openjdk.java.net/~ysuenaga/JDK-8068589/webrev.02/
> 
> Could you review it again?
> 
> 
> Thanks,
> 
> Yasumasa
> 
> 
> On 2015/01/28 5:06, Kirk Pepperdine wrote:
> > Hi Staffan,
> > 
> > > > 
> > > > Anyway, it’s a record in a GC log so I don’t see the value of GC.run. \
> > > > Certainly “DiagCmd" or even "Diagnostic Command” seems sufficient given the \
> > > > context.
> > > 
> > > Let’s go with “Diagnostic Command”, then.
> > 
> > Thank you!
> > 
> > Regards,
> > Kirk
> > 


[prev in list] [next in list] [prev in thread] [next in thread]