[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8067945: SVC jdk/test/* should be cleaned from JRE layout dependency (corrected per the
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2015-01-22 13:38:06
Message-ID: 3CE0919A-FB6B-4E45-8BE4-8F67F24D7DB3 () oracle ! com
[Download RAW message or body]

Looks good!

Thanks,
/Staffan


> On 22 jan 2015, at 11:59, Alexander Kulyakhtin <alexander.kulyakhtin@oracle.com> \
> wrote: 
> 
> Could someone from the reviewers group, please, review the changes, if possible, so \
> they can be pushed?  
> bug: https://bugs.openjdk.java.net/browse/JDK-8067945
> webrev: http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8067945/webrev.01/
> 
> Thank you very much
> Alex
> 
> ----- Original Message -----
> From: yekaterina.kantserova@oracle.com
> To: alexander.kulyakhtin@oracle.com
> Cc: serviceability-dev@openjdk.java.net
> Sent: Wednesday, January 21, 2015 3:07:06 PM GMT +04:00 Abu Dhabi / Muscat
> Subject: Re: RFR: JDK-8067945: SVC jdk/test/* should be cleaned from JRE layout \
> dependency (corrected per the review findings) 
> Looks god to me (not a reviewer).
> 
> // Katja
> 
> On 01/21/2015 11:23 AM, Alexander Kulyakhtin wrote:
> > Hi Katia,
> > 
> > Please, find attached the jdk.patch containing the changes per your findings. The \
> > patch has been made by running the webrev tool. 
> > Best regards,
> > Alex
> > 
> > ----- Original Message -----
> > From: yekaterina.kantserova@oracle.com
> > To: alexander.kulyakhtin@oracle.com, serviceability-dev@openjdk.java.net
> > Sent: Wednesday, January 21, 2015 12:11:58 PM GMT +04:00 Abu Dhabi / Muscat
> > Subject: Re: RFR: JDK-8067945: SVC jdk/test/* should be cleaned from JRE layout \
> > dependency (corrected per the review findings) 
> > Hi Alex,
> > 
> > Comments bellow should be removed. You don't need to make a webrev for
> > it, only the changes are included in the final patch.
> > 
> > test/com/sun/jdi/connect/spi/JdiLoadedByCustomLoader.java
> > 
> > 39         // create files from given arguments and tools.jar
> > 
> > test/com/sun/tools/attach/BasicTests.java
> > 
> > 81         // Need to add jdk/lib/tools.jar to classpath.
> > 
> > 
> > Best regards,
> > Katja (not a reviewer)
> > 
> > 
> > 
> > On 01/19/2015 05:00 PM, Alexander Kulyakhtin wrote:
> > > Hi,
> > > 
> > > Could you, please, review the fix below.
> > > 
> > > To adress the previous review findings any referenes to "test.jdk" have been \
> > > removed. 
> > > bug: https://bugs.openjdk.java.net/browse/JDK-8067945
> > > webrev: http://cr.openjdk.java.net/~eistepan/~akulyakhtin/8067945/webrev.01/
> > > 
> > > References to tools.jar are removed from the tests as jdk9 drops tools.jar
> > > 
> > > Thanks,
> > > Alex
> 


[prev in list] [next in list] [prev in thread] [next in thread]