[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): 6618335: ThreadReference.stop(null) throws NPE instead of InvalidTypeException
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2014-11-28 6:31:00
Message-ID: 4B61A607-B46E-4028-9409-5D2E35C47F90 () oracle ! com
[Download RAW message or body]

Looks good!

Thanks,
/Staffan

> On 27 nov 2014, at 23:37, Erik Gahlin <erik.gahlin@oracle.com> wrote:
> 
> Hi,
> 
> Could I have a review of a small fix to the JDI implementation.
> 
> If ThreadReference#stop(null) is called, a NPE is triggered before the code that \
> should throw an InvalidTypeException is reached. Fix is to use \
> validateMirrorOrNull, which ignores the vaildation if it's null. 
> This is similar to how ThreadReference#forceEarlyReturn is implemented. Tested with \
> jdk_jdi. 
> Thanks
> Erik
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-6618335
> 
> Webrev:
> http://cr.openjdk.java.net/~egahlin/6618335/


[prev in list] [next in list] [prev in thread] [next in thread]