[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: RFR(S): 8065361: Fixup headers and definitions for INCLUDE_TRACE
From: Markus Grönlund <markus.gronlund () oracle ! com>
Date: 2014-11-19 14:59:40
Message-ID: 8a9cdebe-1841-47ee-b6c3-35269d80b4f6 () default
[Download RAW message or body]
Thanks Stefan and Staffan for reviewing!
/Markus
From: Staffan Larsen
Sent: den 19 november 2014 15:56
To: Markus Grönlund
Cc: serviceability-dev@openjdk.java.net; Stefan Karlsson
Subject: Re: RFR(S): 8065361: Fixup headers and definitions for INCLUDE_TRACE
Looks good!
Thanks,
/Staffan
On 19 nov 2014, at 15:28, Markus Grönlund <HYPERLINK \
"mailto:markus.gronlund@oracle.com"markus.gronlund@oracle.com> wrote:
Greetings,
Kindly asking for reviews for the following changeset to clean up the usage of the \
INCLUDE_TRACE define:
Bug: https://bugs.openjdk.java.net/browse/JDK-8065361
Webrev: http://cr.openjdk.java.net/~mgronlun/8065361/webrev01/
Description:
#include "utilities/macros.hpp" for every compilation unit using INCLUDE_TRACE. \
Header include guards comments updated to C++ style.
Thanks in advance
Markus
[Attachment #3 (text/html)]
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta name=Generator content="Microsoft \
Word 12 (filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=SV link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks \
Stefan and Staffan for reviewing!<o:p></o:p></span></p><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>/Markus<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p \
class=MsoNormal><b><span lang=EN-US \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span \
lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Staffan Larsen \
<br><b>Sent:</b> den 19 november 2014 15:56<br><b>To:</b> Markus \
Grönlund<br><b>Cc:</b> serviceability-dev@openjdk.java.net; Stefan \
Karlsson<br><b>Subject:</b> Re: RFR(S): 8065361: Fixup headers and definitions for \
INCLUDE_TRACE<o:p></o:p></span></p></div></div><p \
class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Looks \
good!<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>Thanks,<o:p></o:p></p></div><div><p \
class=MsoNormal>/Staffan<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><div><p class=MsoNormal>On 19 nov 2014, \
at 15:28, Markus Grönlund <<a \
href="mailto:markus.gronlund@oracle.com">markus.gronlund@oracle.com</a>> \
wrote:<o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p><div><div><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>Greetings,<o:p></o:p></span></p></div><div><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'> <o:p></o:p></span></p></div><div><p \
class=MsoNormal><span lang=EN-US \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>Kindly asking for reviews \
for the following changeset to clean up the usage of the INCLUDE_TRACE \
define:</span><span style='font-size:11.0pt;font-family:"Calibri","sans-serif"'><o:p></o:p></span></p></div><div><p \
class=MsoNormal><span lang=EN-US \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'> </span><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'><o:p></o:p></span></p></div><div><p \
class=MsoNormal><span lang=EN-US \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>Bug:<span \
class=apple-converted-space> </span><a \
href="https://bugs.openjdk.java.net/browse/JDK-8065361"><span \
style='color:purple'>https://bugs.openjdk.java.net/browse/JDK-8065361</span></a></span><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'><o:p></o:p></span></p></div><div><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>Webrev:<span \
class=apple-converted-space> </span><a \
href="http://cr.openjdk.java.net/~mgronlun/8065361/webrev01/"><span \
style='color:purple'>http://cr.openjdk.java.net/~mgronlun/8065361/webrev01/</span></a><o:p></o:p></span></p></div><div><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'> <o:p></o:p></span></p></div><div><p \
class=MsoNormal><span lang=EN-US \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>Description:</span><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'><o:p></o:p></span></p></div><div><p \
class=MsoNormal><span lang=EN-US \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>#include \
”utilities/macros.hpp” for every compilation unit using INCLUDE_TRACE. \
Header include guards comments updated to C++ style.</span><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'><o:p></o:p></span></p></div><div><p \
class=MsoNormal><span lang=EN-US \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'> </span><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'><o:p></o:p></span></p></div><div><p \
class=MsoNormal><span lang=EN-US \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>Thanks in \
advance</span><span style='font-size:11.0pt;font-family:"Calibri","sans-serif"'><o:p></o:p></span></p></div><div><p \
class=MsoNormal><span lang=EN-US \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'>Markus</span><span \
style='font-size:11.0pt;font-family:"Calibri","sans-serif"'><o:p></o:p></span></p></div></div></blockquote></div><p \
class=MsoNormal><o:p> </o:p></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic