[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): 6542634: TEST BUG: MISC_REGRESSION tests need to have minimum timeouts examined
From:       Jaroslav Bachorik <jaroslav.bachorik () oracle ! com>
Date:       2014-11-18 15:22:45
Message-ID: 546B6445.6070908 () oracle ! com
[Download RAW message or body]

Looks good!

-JB-

On 11/18/2014 03:57 PM, Yekaterina Kantserova wrote:
> Jaroslav, Erik, thanks!
>
> The new webrev can be found here
> http://cr.openjdk.java.net/~ykantser/6542634/webrev.01/
>
> // Katja
>
>
> On 11/18/2014 03:36 PM, Jaroslav Bachorik wrote:
>> On 11/18/2014 02:05 PM, Yekaterina Kantserova wrote:
>>> Hi Jaroslav,
>>>
>>> Thanks for the quick review!
>>>
>>> test/sun/tools/jinfo/JInfoRunningProcessFlagTest.java is added to the
>>> ProblemList because it contains this case:
>>>
>>>    90     private static void testInvalidFlag() throws Exception {
>>>    91         OutputAnalyzer output = JInfoHelper.jinfo("-flag",
>>> "monkey");
>>>    92         assertNotEquals(output.getExitValue(), 0, "A non-zero
>>> exit code should be returned for invalid flag");
>>>    93     }
>>>
>>> which will fail due to https://bugs.openjdk.java.net/browse/JDK-6734748.
>>> I've been thinking about to break it out into a separate class, but then
>>> decided to group it together with other flag-tests. What would you
>>> recommend?
>>
>> Ok. This sounds reasonable. Let's keep it this way.
>>
>> -JB-
>>
>>>
>>> The change for L68 will be in the next review.
>>>
>>> // Katja
>>>
>>>
>>>
>>> On 11/18/2014 12:20 PM, Jaroslav Bachorik wrote:
>>>> Hi Katja,
>>>>
>>>> test/ProblemList.txt - you are adding seemingly unrelated issue here
>>>>
>>>> test/sun/tools/jinfo/JInfoHelper.java
>>>> L68 - processBuilder.command(...) could be moved to L67 and do new
>>>> ProcessBuilder(launcher.getCommand()) - it communicates the purpose
>>>> better
>>>>
>>>> Cheers,
>>>>
>>>> -JB-
>>>>
>>>>
>>>> On 11/18/2014 12:07 PM, Yekaterina Kantserova wrote:
>>>>> Hi,
>>>>>
>>>>> Could I please have a review of this fix.
>>>>>
>>>>> In this fix I take an opportunity to refactor sun/tools/jinfo/Basic.sh
>>>>> and to add more tests for jinfo utility. sun/tools/jinfo/Basic.sh is a
>>>>> last unstable test among tests listed
>>>>> inhttps://bugs.openjdk.java.net/browse/JDK-6542634  that's why I've
>>>>> chosen to use this bug number instead of creating a new one.
>>>>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-6542634
>>>>> webrev: http://cr.openjdk.java.net/~ykantser/6542634/webrev.00/
>>>>>
>>>>> The tests have been run and passed on all basic platforms.
>>>>>
>>>>> Thanks,
>>>>> Katja
>>>>>
>>>>
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]