[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR 8061616: HotspotDiagnosticMXBean.getVMOption() throws IllegalArgumentException for flags of 
From:       Mandy Chung <mandy.chung () oracle ! com>
Date:       2014-10-29 19:34:19
Message-ID: 5451413B.2080807 () oracle ! com
[Download RAW message or body]


On 10/29/2014 6:50 AM, Jaroslav Bachorik wrote:
> Please review the following change
>
> Issue  : https://bugs.openjdk.java.net/browse/JDK-8061616
> Webrev :
>   (jdk): http://cr.openjdk.java.net/~jbachorik/8061616/jdk/webrev.00/
>   (hotspot): 
> http://cr.openjdk.java.net/~jbachorik/8061616/hotspot/webrev.00/
>

share/classes/sun/management/HotSpotDiagnostic.java
    line 105-110, 117-122: you can replace with new IAE(String, Throwable cause)
    The original code was written before that IAE constructor was added.

test/com/sun/management/HotSpotDiagnosticMXBean/GetDoubleVMOption.java
    you can take out line 28

Looks okay otherwise.

Mandy
[prev in list] [next in list] [prev in thread] [next in thread]