[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): 8060707: jdwp accept invalid address ':'
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2014-10-29 10:06:25
Message-ID: 5450BC21.9050101 () oracle ! com
[Download RAW message or body]

Looks good for me.

-Dmitry

On 2014-10-29 11:45, Sergei Kovalev wrote:
> Hi Team,
> 
> Could you please review following patch that fix the tests.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8060707
> Webrev: http://cr.openjdk.java.net/~iignatyev/skovalev/8060707/webrev.00/
> 
> Problem:
> A test failed because of wrong assumption that stderr always starts with
> "ERROR" string in case of error
> 
> Cause:
> On some embedded platforms (ARM-SFLT) in case we provide VM option:
> "-XX:NativeMemoryTracking=detail" VM print out a warning first: "/NMT
> detail is not supported on this platform. Using NMT summary instead./"
> ant then printout error message.
> 
> Solution:
> Look up "^ERROR: transport error " pattern in whole message, not only in
> the very begin.
> 
> Testing done:
> Test launched manually on the host where it initially failed. Used
> different set of VM options to get different kind of output.
> 
> -- 
> With best regards,
> Sergei
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
[prev in list] [next in list] [prev in thread] [next in thread]