[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [PATCH] Return -1 after throwing internal error
From:       Mandy Chung <mandy.chung () oracle ! com>
Date:       2014-10-21 2:21:17
Message-ID: 5445C31D.7030106 () oracle ! com
[Download RAW message or body]

Hi Xiaoguang,

On 10/20/2014 6:31 PM, Xiaoguang Sun wrote:
> Hi All,
> 
> I recently discovered some inconsistency in UnixOperatingSystem_md.c
> that do now return -1 after throwing internal error. It usually
> shouldn't be a problem, but making it more consistent to other code
> within the same file shouldn't be a bad idea.

I'm including serviceability-dev for your patch as UnixOperatingSystem_md.c
belongs to serviceability.

Are you working on a clone of jdk9/dev repo?  \
src/solaris/native/com/sun/management/UnixOperatingSystem_md.c looks like jdk7 \
source.

It has been renamed to \
src/java.management/unix/native/libmanagement/OperatingSystemImpl.c [1]. Can you \
rebase your patch to the latest jdk9 source and send it to serviceability-dev?

Mandy
[1] http://hg.openjdk.java.net/jdk9/dev/jdk/


[prev in list] [next in list] [prev in thread] [next in thread]