[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: jmx-dev RFR 8058089: api/javax_management/loading/MLetArgsSupport.html\#MLetArgsSupportTest0001
From:       Daniel Fuchs <daniel.fuchs () oracle ! com>
Date:       2014-09-11 10:38:02
Message-ID: 54117B8A.7070101 () oracle ! com
[Download RAW message or body]

Hi Jaroslav,

This looks good.

best regards,

-- daniel

On 9/11/14 11:54 AM, Jaroslav Bachorik wrote:
> Please, review the following regression fix
>
> Issue  : https://bugs.openjdk.java.net/browse/JDK-8058089
> Webrev : http://cr.openjdk.java.net/~jbachorik/8058089/webrev.00
>
> The regression was introduced by an en-mass update of new
> `Integer(param)` to `Integer.valueOf(param)`. For some reason in the
> MLet code only `param` was used instead of `Integer.valueOf(param)`.
> I've fixed this problem and also took the liberty to convert new Float()
> and new Double() to .valueOf(...) form. I also added a reg test
> asserting the correctness of param conversions performed by the MLet class.
>
>
> Thanks,
>
> -JB-

[prev in list] [next in list] [prev in thread] [next in thread]