[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: 8057776 Misc cleanups of the attach code
From: Staffan Larsen <staffan.larsen () oracle ! com>
Date: 2014-09-08 18:27:20
Message-ID: 0DDAAD75-5841-449D-8128-5F9970DBF968 () oracle ! com
[Download RAW message or body]
Thanks for testing it out.
/Staffan
On 8 sep 2014, at 19:34, Volker Simonis <volker.simonis@gmail.com> wrote:
> Hi Staffan,
>
> I've just successfully built on AIX with your proposed changes.
>
> Everything looks fine, so thumbs up from me and thanks for pushing the additional \
> changes!
> Regards,
> Volker
>
>
>
> On Mon, Sep 8, 2014 at 3:04 PM, Staffan Larsen <staffan.larsen@oracle.com> wrote:
> Hi Volker,
>
> Unfortunately I had already pushed the change. I filed a new bug for the AIX work: \
> JDK-8057778 and the changes are below. If you can review them, I will push it soon. \
> Thanks and sorry I forgot aix,
> /Staffan
>
>
> diff --git a/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java \
> b/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
>
> --- a/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
> +++ b/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
> @@ -28,8 +28,6 @@
> import com.sun.tools.attach.VirtualMachine;
> import com.sun.tools.attach.VirtualMachineDescriptor;
> import com.sun.tools.attach.AttachNotSupportedException;
> -import com.sun.tools.attach.spi.AttachProvider;
> -
> import java.io.IOException;
>
> // Based on linux/classes/sun/tools/attach/AttachProviderImpl.java.
> @@ -40,9 +38,6 @@
> */
> public class AttachProviderImpl extends HotSpotAttachProvider {
>
> - // perf counter for the JVM version
> - private static final String JVM_VERSION = "java.property.java.vm.version";
> -
> public AttachProviderImpl() {
> }
>
> diff --git a/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java \
> b/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java
>
> --- a/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java
> +++ b/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java
> @@ -25,14 +25,12 @@
> */
> package sun.tools.attach;
>
> -import com.sun.tools.attach.VirtualMachine;
> import com.sun.tools.attach.AgentLoadException;
> import com.sun.tools.attach.AttachNotSupportedException;
> import com.sun.tools.attach.spi.AttachProvider;
> import java.io.InputStream;
> import java.io.IOException;
> import java.io.File;
> -import java.util.Properties;
>
> // Based on linux/classes/sun/tools/attach/VirtualMachineImpl.java.
>
>
> On 8 sep 2014, at 14:48, Volker Simonis <volker.simonis@gmail.com> wrote:
>
> > hi Staffen,
> >
> > the change looks good, but could you please also change \
> > src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
> > Thanks,
> > Volker
> >
> >
> >
> > On Mon, Sep 8, 2014 at 2:45 PM, Staffan Larsen <staffan.larsen@oracle.com> wrote:
> > Thank you, all.
> >
> > On 8 sep 2014, at 14:39, Daniel Fuchs <daniel.fuchs@oracle.com> wrote:
> >
> > > Hi Staffan,
> > >
> > > Looks good!
> > >
> > > -- daniel
> > >
> > > On 9/8/14 2:23 PM, Staffan Larsen wrote:
> > > > Please review this simple fix for some small issues in the attach code:
> > > > - Removed unused imports
> > > > - Removed unused fields
> > > > - Update @since for startManagementAgent() and startLocalManagementAgent() \
> > > > since these were just backported to 1.8
> > > > - Simplified a for-loop in a test
> > > >
> > > > bug: https://bugs.openjdk.java.net/browse/JDK-8057776
> > > > webrev: http://cr.openjdk.java.net/~sla/8057776/webrev.00/
> > > >
> > > > Thanks,
> > > > /Staffan
> > > >
> > >
> >
> >
>
>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;">Thanks for testing it \
out.<div><br></div><div>/Staffan</div><div><br><div style=""><div>On 8 sep 2014, at \
19:34, Volker Simonis <<a \
href="mailto:volker.simonis@gmail.com">volker.simonis@gmail.com</a>> \
wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div \
dir="ltr"><div><div><div><div>Hi Staffan,<br><br></div>I've just successfully built \
on AIX with your proposed changes.<br><br></div>Everything looks fine, so thumbs up \
from me and thanks for pushing the additional \
changes!<br><br></div>Regards,<br></div>Volker<br><br></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 8, 2014 at 3:04 PM, \
Staffan Larsen <span dir="ltr"><<a href="mailto:staffan.larsen@oracle.com" \
target="_blank">staffan.larsen@oracle.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div style="word-wrap:break-word">Hi \
Volker,<div><br></div><div>Unfortunately I had already pushed the change. I filed a \
new bug for the AIX work: JDK-8057778 and the changes are below. If you can \
review them, I will push it soon.</div><div><br></div><div><div>Thanks and sorry I \
forgot aix,</div><div>/Staffan</div></div><div><br></div><div><br></div><div><div>diff \
--git a/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java \
b/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java</div><div>--- \
a/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java</div><div>+++ \
b/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java</div><div>@@ \
-28,8 +28,6 @@</div><div> import \
com.sun.tools.attach.VirtualMachine;</div><div> import \
com.sun.tools.attach.VirtualMachineDescriptor;</div><div> import \
com.sun.tools.attach.AttachNotSupportedException;</div><div>-import \
com.sun.tools.attach.spi.AttachProvider;</div><div>-</div><div> import \
java.io.IOException;</div><div><br></div><div> // Based on \
linux/classes/sun/tools/attach/AttachProviderImpl.java.</div><div>@@ -40,9 +38,6 \
@@</div><div> */</div><div> public class AttachProviderImpl extends \
HotSpotAttachProvider {</div><div><br></div><div>- // perf counter for \
the JVM version</div><div>- private static final String JVM_VERSION = \
"java.property.java.vm.version";</div><div>-</div><div> public \
AttachProviderImpl() {</div><div> }</div><div><br></div><div>diff \
--git a/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java \
b/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java</div><div>--- \
a/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java</div><div>+++ \
b/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java</div><div>@@ \
-25,14 +25,12 @@</div><div> */</div><div> package \
sun.tools.attach;</div><div><br></div><div>-import \
com.sun.tools.attach.VirtualMachine;</div><div> import \
com.sun.tools.attach.AgentLoadException;</div><div> import \
com.sun.tools.attach.AttachNotSupportedException;</div><div> import \
com.sun.tools.attach.spi.AttachProvider;</div><div> import \
java.io.InputStream;</div><div> import \
java.io.IOException;</div><div> import java.io.File;</div><div>-import \
java.util.Properties;</div><div><br></div><div> // Based on \
linux/classes/sun/tools/attach/VirtualMachineImpl.java.</div></div><div><div \
class="h5"><div><br></div><div><br><div><div>On 8 sep 2014, at 14:48, Volker Simonis \
<<a href="mailto:volker.simonis@gmail.com" \
target="_blank">volker.simonis@gmail.com</a>> wrote:</div><br><blockquote \
type="cite"><div dir="ltr"><div><div>hi Staffen,<br><br>the change looks good, but \
could you please also change \
src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java<br><br></div>Thanks,<br></div>Volker<br><br></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 8, 2014 at 2:45 PM, \
Staffan Larsen <span dir="ltr"><<a href="mailto:staffan.larsen@oracle.com" \
target="_blank">staffan.larsen@oracle.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Thank you, all.<br> <div><br>
On 8 sep 2014, at 14:39, Daniel Fuchs <<a href="mailto:daniel.fuchs@oracle.com" \
target="_blank">daniel.fuchs@oracle.com</a>> wrote:<br> <br>
> Hi Staffan,<br>
><br>
> Looks good!<br>
><br>
> -- daniel<br>
><br>
> On 9/8/14 2:23 PM, Staffan Larsen wrote:<br>
>> Please review this simple fix for some small issues in the attach code:<br>
>> - Removed unused imports<br>
>> - Removed unused fields<br>
>> - Update @since for startManagementAgent() and startLocalManagementAgent() \
since these were just backported to 1.8<br> >> - Simplified a for-loop in a \
test<br> >><br>
>> bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8057776" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8057776</a><br> >> \
webrev: <a href="http://cr.openjdk.java.net/~sla/8057776/webrev.00/" \
target="_blank">http://cr.openjdk.java.net/~sla/8057776/webrev.00/</a><br> \
>><br> >> Thanks,<br>
>> /Staffan<br>
>><br>
><br>
<br>
</div></blockquote></div><br></div>
</blockquote></div><br></div></div></div></div></blockquote></div><br></div>
</blockquote></div><br></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic