[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (S): JDK-8056242: Add function to return structured information about loaded libraries.
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2014-08-28 14:21:25
Message-ID: 6A0CFAF8-C21F-4284-ACB2-AF9AA9DE8E52 () oracle ! com
[Download RAW message or body]

Hi Fredrik,

A couple of comments:
- I would prefer if the new callback was unified with the one that exists on Windows \
                so that we have only on callback-based API for listing dynamic \
                libraries.
- If you do that, then would you also clean up enumerate_modules() on windows to get \
                rid of the non-NT support?
- Smaller: I think “address” is a better type to use instead of “u8”.

Thanks
/Staffan


On 28 aug 2014, at 15:54, Fredrik Arvidsson <fredrik.arvidsson@oracle.com> wrote:

> Hi
> 
> Please help me review this small enhancement.
> 
> Webrev: http://cr.openjdk.java.net/~farvidsson/8056242/webrev.00/index.html
> Bug: https://bugs.openjdk.java.net/browse/JDK-8056242
> 
> Cheers
> /F


[prev in list] [next in list] [prev in thread] [next in thread]