[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: Review request: 8055230: Rename attach provider implementation class
From:       Mandy Chung <mandy.chung () oracle ! com>
Date:       2014-08-26 15:53:07
Message-ID: 53FCAD63.2090806 () oracle ! com
[Download RAW message or body]


On 8/26/2014 3:59 AM, Staffan Larsen wrote:
> There are some differences in the AttachProvideImpl files. Most notably=
 the windows version is very different. Linux, Bsd and Aix are the same. =
The Solaris version has a minor difference in the  =93public String type(=
)=94 implementation. The Linux, Bsd, Aix and Solaris versions could proba=
bly be unified.

I would leave this as it is and further unification can be done
as future cleanup.  Thanks for all the review.

Mandy

>
> /Staffan
>
> On 26 aug 2014, at 12:40, Daniel Fuchs <daniel.fuchs@oracle.com> wrote:
>
>> Hi Mandy,
>>
>> I'm seeing some small differences in the various VirtualMachineImpl.ja=
va
>> files, but if I'm not mistaken, all the new AttachProviderImpl.java lo=
ok
>> all the same. I wonder if the patch could be further simplified by
>> moving AttachProviderImpl.java to jdk.attach/share/classes (unless
>> there's a reason to keep all the different copies)...
>>
>> best regards,
>>
>> -- daniel
>>
>> On 8/26/14 6:29 AM, Mandy Chung wrote:
>>> Webrev:
>>>     http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/
>>>
>>> This patch renames the class name of attach provider implementation c=
lass
>>> to be the same for all platforms.  This simplifies the build logic an=
d
>>> removes the need for generating the service config file at build time.
>>>
>>> The files renamed are
>>>     unix/classes/sun/tools/attach/${OS}VirtualMachine.java
>>>       -> ${OS}/classes/sun/tools/attach/VirtualMachineImpl.java
>>>     unix/classes/sun/tools/attach/${OS}AttachProvider.java
>>>       -> ${OS}/classes/sun/tools/attach/VirtualMachineImpl.java
>>>
>>>     ${OS}/classes/sun/tools/attach/${OS}VirtualMachine.java
>>>       -> ${OS}/classes/sun/tools/attach/VirtualMachineImpl.java
>>>     ${OS}/classes/sun/tools/attach/${OS}AttachProvider.java
>>>       -> ${OS}/classes/sun/tools/attach/VirtualMachineImpl.java
>>>
>>> and also corresponding native files.
>>>
>>> Mandy
>>>
>>>

[prev in list] [next in list] [prev in thread] [next in thread]