[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254
From:       "Daniel D. Daugherty" <daniel.daugherty () oracle ! com>
Date:       2014-08-21 15:05:22
Message-ID: 53F60AB2.90809 () oracle ! com
[Download RAW message or body]

Here's the commit message:

$ cat commit.txt
8055338: (process) Add instrumentation to help diagnose JDK-6573254
Reviewed-by: dcubed, ohair, iklam, dholmes, sspitsyn, sla

I will commit the changeset as 'igerasim'.

Didn't think a summary line was needed.

Dan


On 8/21/14 8:21 AM, Daniel D. Daugherty wrote:
> The correct repository would be RT_Baseline. What testing has been
> run on your fix? I know you've done a control build so that covers
> JPRT testing.
>
> I'll prep a repo for sponsoring the push, but I'll hold off pushing
> until I know what testing has been done.
>
> Dan
>
>
> On 8/21/14 4:57 AM, Ivan Gerasimov wrote:
>> Thanks for review!
>>
>> Could someone please sponsor it for me?
>> I'm not sure what the correct repository is.
>>
>> Sincerely yours,
>> Ivan
>>
>> On 21.08.2014 11:46, serguei.spitsyn@oracle.com wrote:
>>> +1
>>>
>>> On 8/20/14 10:57 PM, Staffan Larsen wrote:
>>>> Looks good to me. Let’s see what it uncovers.
>>>>
>>>> /Staffan
>>>>
>>>> On 20 aug 2014, at 21:36, Ivan Gerasimov 
>>>> <ivan.gerasimov@oracle.com> wrote:
>>>>
>>>>> Hello everyone!
>>>>>
>>>>> Here's the third version of the webrev:
>>>>> http://cr.openjdk.java.net/~igerasim/8055338/2/webrev/
>>>>>
>>>>> The control build of the previous one was causing a lot of test 
>>>>> failures.
>>>>> This one seems to be innocent enough: no new test failures so far.
>>>>>
>>>>> Additionally, this version keeps the timing around the thread exit 
>>>>> close to original, which might be important if we deal with a race.
>>>>>
>>>>> Sincerely yours,
>>>>> Ivan
>>>>>
>>>
>>>
>>>
>>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]