[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8055673 test/com/sun/jdi/ShellScaffold.sh does not honor -javaoption
From:       Mandy Chung <mandy.chung () oracle ! com>
Date:       2014-08-20 15:24:57
Message-ID: 53F4BDC9.5020201 () oracle ! com
[Download RAW message or body]


On 8/20/2014 6:06 AM, Staffan Larsen wrote:
> All,
>
> Running something like:
>
>    jtreg -javaoption:-Xmixed jdk/test/com/sun/jdi/RedefineStep.sh
>
> Will print an error message:
>
>    test/com/sun/jdi/ShellScaffold.sh: line 885: -Xmixed: command not found
>
> The test will not fail, but the -javaoption argument will be ignored.
>
> The fix is to add some missing quotes:
>
> --- a/test/com/sun/jdi/ShellScaffold.sh
> +++ b/test/com/sun/jdi/ShellScaffold.sh
> @@ -882,7 +882,7 @@
>
>   startDebuggee()
>   {
> -    args=$TESTVMOPTS $TESTJAVAOPTS
> +    args="$TESTVMOPTS $TESTJAVAOPTS"
>
>       if [ ! -z "$args" ] ; then
>          echo "--Starting debuggee with args from TESTVMOPTS and/or TESTJAVAOPTS: $args”
>

Looks okay.

Mandy

[prev in list] [next in list] [prev in thread] [next in thread]