[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR(XS): 8055012 - [TESTBUG] NMTHelper fails to parse NMT output
From: "olivier.lagneau () oracle ! com" <olivier ! lagneau () oracle ! com>
Date: 2014-08-18 11:39:23
Message-ID: 53F1E5EB.9050602 () oracle ! com
[Download RAW message or body]
Hi Christian,
Looks good !
Olivier.
On 15/08/2014 16:55, Christian Tornqvist wrote:
>
> Hi,
>
> This is a small update to NMTHelper.java to make it work with recent
> changes in the NMT implementation that changed the output format a bit.
>
> I’ve tested the change locally using
> java\lang\instrument\RedefineBigClass.sh and
> java\lang\instrument\RetransformBigClass.sh
>
> Webrev doesn’t seem to like whitespace-only changes so I can’t post a
> webrev, I’m pasting the diff here instead:
>
> diff -r 362a6ea9bc84 test/java/lang/instrument/NMTHelper.java
>
> --- a/test/java/lang/instrument/NMTHelper.java Thu Aug 14 15:54:04
> 2014 -0700
>
> +++ b/test/java/lang/instrument/NMTHelper.java Fri Aug 15 10:43:15
> 2014 -0400
>
> @@ -32,8 +32,8 @@
>
> executeDcmd("vmNativeMemory", "baseline");
>
> }
>
> - // Total: reserved=3484685KB +293KB, committed=266629KB +293KB
>
> - private static Pattern totalLine = Pattern.compile("^Total:
> reserved=\\d+KB .*KB, committed=\\d+KB (.*)KB$");
>
> + // Total: reserved=3484685KB +293KB, committed=266629KB +293KB
>
> + private static Pattern totalLine = Pattern.compile("^Total:
> reserved=\\d+KB .*KB, committed=\\d+KB (.*)KB$");
>
> public static long committedDiff() throws Exception {
>
> String res = (String) executeDcmd("vmNativeMemory",
> "detail.diff");
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8055012
>
> Thanks,
>
> Christian
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#C0C0C0" text="#000099">
<tt>Hi Christian,<br>
<br>
Looks good !<br>
<br>
Olivier.</tt>
<div class="moz-cite-prefix">On 15/08/2014 16:55, Christian
Tornqvist wrote:<br>
</div>
<blockquote cite="mid:002f01cfb898$e65120d0$b2f36270$@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This is a small update to NMTHelper.java to
make it work with recent changes in the NMT implementation
that changed the output format a bit.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’ve tested the change locally using
java\lang\instrument\RedefineBigClass.sh and
java\lang\instrument\RetransformBigClass.sh<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Webrev doesn’t seem to like whitespace-only
changes so I can’t post a webrev, I’m pasting the diff here
instead:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">diff -r 362a6ea9bc84
test/java/lang/instrument/NMTHelper.java<o:p></o:p></p>
<p class="MsoNormal">---
a/test/java/lang/instrument/NMTHelper.java Thu Aug 14
15:54:04 2014 -0700<o:p></o:p></p>
<p class="MsoNormal">+++
b/test/java/lang/instrument/NMTHelper.java Fri Aug 15
10:43:15 2014 -0400<o:p></o:p></p>
<p class="MsoNormal">@@ -32,8 +32,8 @@<o:p></o:p></p>
<p class="MsoNormal"> executeDcmd("vmNativeMemory",
"baseline");<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">- // Total: reserved=3484685KB +293KB,
committed=266629KB +293KB<o:p></o:p></p>
<p class="MsoNormal">- private static Pattern totalLine =
Pattern.compile("^Total: reserved=\\d+KB .*KB,
committed=\\d+KB (.*)KB$");<o:p></o:p></p>
<p class="MsoNormal">+ // Total: reserved=3484685KB +293KB,
committed=266629KB +293KB<o:p></o:p></p>
<p class="MsoNormal">+ private static Pattern totalLine =
Pattern.compile("^Total: reserved=\\d+KB .*KB,
committed=\\d+KB (.*)KB$");<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> public static long committedDiff()
throws Exception {<o:p></o:p></p>
<p class="MsoNormal"> String res = (String)
executeDcmd("vmNativeMemory", "detail.diff");<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Bug:<o:p></o:p></p>
<p class="MsoNormal"><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8055012">https://bugs.openjdk.java.net/browse/JDK-8055012</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Christian<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic