[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (M): 8054278: Refactor jps utility tests
From:       Jaroslav Bachorik <jaroslav.bachorik () oracle ! com>
Date:       2014-08-15 10:44:20
Message-ID: 53EDE484.7090700 () oracle ! com
[Download RAW message or body]

On 08/15/2014 12:34 PM, Yekaterina Kantserova wrote:
> Jaroslav,
> 
> Thanks for your review! Could you please be my sponsor and push the fix? The patch \
> file is attached to this mail.

Ok.

-JB-

> 
> // Katja
> 
> 
> 
> ----- Original Message -----
> From: jaroslav.bachorik@oracle.com
> To: serviceability-dev@openjdk.java.net
> Sent: Friday, August 15, 2014 10:19:43 AM GMT +01:00 Amsterdam / Berlin / Bern / \
>                 Rome / Stockholm / Vienna
> Subject: Re: RFR (M): 8054278: Refactor jps utility tests
> 
> Looks good!
> 
> Cheers,
> 
> -JB-
> 
> On 08/14/2014 04:38 PM, Yekaterina Kantserova wrote:
> > My bad - I've used 4.1 fcs b09 nightly build from the past. With the
> > promoted one it works fine.
> > 
> > Please find the updated version here:
> > http://cr.openjdk.java.net/~ykantser/8054278/webrev.01/
> > 
> > // Katja
> > 
> > 
> > 
> > On 08/14/2014 04:11 PM, Staffan Larsen wrote:
> > > It should work. Most of the test in jdk/test/com/sun/jdi uses "@run
> > > driver" and runs well with 4.1 fcs b09.
> > > 
> > > /Staffan
> > > 
> > > 
> > > On 14 aug 2014, at 14:16, Yekaterina Kantserova
> > > <yekaterina.kantserova@oracle.com
> > > <mailto:yekaterina.kantserova@oracle.com>> wrote:
> > > 
> > > > Opps, it doesn't seem we can use "@run driver" with jtreg 4.1 b09. I
> > > > get following error:
> > > > 
> > > > ...
> > > > * @build jdk.testlibrary.* JpsHelper JpsBase
> > > > * @run driver TestJpsClass
> > > > ...
> > > > TEST: sun/tools/jps/TestJpsClass.java
> > > > TEST RESULT: Error. Bad action for script: driver
> > > > ...
> > > > 
> > > > // Katja
> > > > 
> > > > 
> > > > 
> > > > On 08/14/2014 02:07 PM, Yekaterina Kantserova wrote:
> > > > > Leonid,
> > > > > 
> > > > > Yes, it seems to be a good idea. I'll check how it works.
> > > > > 
> > > > > // Katja
> > > > > 
> > > > > 
> > > > > On 08/14/2014 01:55 PM, Leonid Mesnik wrote:
> > > > > > Katya
> > > > > > 
> > > > > > I am not reviewing tests, just have small comment.
> > > > > > I think it would be better to use '@run driver' instead of '@run
> > > > > > main' in these tests.
> > > > > > 
> > > > > > Leonid
> > > > > > 
> > > > > > On 14.08.2014 15:40, Yekaterina Kantserova wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > Could I please have a review of this fix.
> > > > > > > 
> > > > > > > webrev:http://cr.openjdk.java.net/~ykantser/8054278/webrev.00/
> > > > > > > bug:https://bugs.openjdk.java.net/browse/JDK-8054278
> > > > > > > 
> > > > > > > As of today the test/jdk/sun/tools/jps tests are a number of shell and \
> > > > > > > awk scripts that test only a few combinations of jps args. The tests \
> > > > > > > also used to fail intermittently due to timing issues, e.g.JDK-7091195  \
> > > > > > > <https://bugs.openjdk.java.net/browse/JDK-7091195>  andJDK-6542634  \
> > > > > > > <https://bugs.openjdk.java.net/browse/JDK-6542634>. In order to make \
> > > > > > > tests more stable and make sure all combinations of arguments are \
> > > > > > > tested the test will be refactored using jdk.testlibrary functionality. \
> > > > > > >  The tests have been run on all basic platforms.
> > > > > > > 
> > > > > > > Thanks,
> > > > > > > Katja
> > > > > > 
> > > > > 
> > > > 
> > > 
> > 
> 


[prev in list] [next in list] [prev in thread] [next in thread]