[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: RFR(XS): 8049324: interpretedVFrame::expressions to index oopmap correctly
From:       Markus Grönlund <markus.gronlund () oracle ! com>
Date:       2014-07-05 18:16:35
Message-ID: 63e21ba8-75d6-4072-9aa4-12581e3beb7a () default
[Download RAW message or body]

Coleen and Serguei,

Again, thanks for your reviews.

/Markus


-----Original Message-----
From: Coleen Phillimore 
Sent: den 5 juli 2014 19:08
To: hotspot-runtime-dev@openjdk.java.net
Subject: Re: RFR(XS): 8049324: interpretedVFrame::expressions to index oopmap \
correctly


Looks good, not that I noticed the indexing problem in the first place...

Coleen

On 7/4/14, 7:43 AM, Markus Grönlund wrote:
> Greetings,
> 
> 
> 
> In the process of trying to make the fix for \
> https://bugs.openjdk.java.net/browse/JDK-8039905 more readable, I messed up the \
> indexing of into the oopmap for the expression slots (in addition to being lazy on \
> testing the new patch suggestion.) 
> 
> 
> This omission made for a few additional failures in nightly testing - my bad.
> 
> 
> 
> This fix will remedy this problem.
> 
> 
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8049324
> 
> webrev: http://cr.openjdk.java.net/~mgronlun/8049324/webrev01/
> 
> 
> 
> Local testing run (Windows x64):
> 
> 
> 
> nsk/jdi*
> 
> nsk/jvmti*
> 
> 
> 
> Sorry for any inconvenience caused by this
> 
> 
> 
> Regards
> 
> Markus
> 
> 
> 
> 
> 
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]