[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: Backout fix for 8032901: WaitForMultipleObjects() return value not handled appropriately
From: Staffan Larsen <staffan.larsen () oracle ! com>
Date: 2014-06-19 10:55:35
Message-ID: 2C54F116-9EA3-430A-9E55-F9E108658B87 () oracle ! com
[Download RAW message or body]
On 19 jun 2014, at 11:11, Alan Bateman <Alan.Bateman@oracle.com> wrote:
> On 19/06/2014 10:06, Staffan Larsen wrote:
> > This fix was intended to catch a supposedly rare error return value from \
> > WaitForMultipleObjects in the shared memory transport for JDI. Unfortunately the \
> > error is not so rare (which should have been discovered during testing of the \
> > fix) and the fix has caused all the JDI tests on windows to become unstable.
> > While we investigate if the fix can be applied together with changes in the code \
> > (so that the error does not happen), I would like to backout the fix.
> > The backout will also have to be applied to 8u20 and 7u80 since the fix was \
> > backported there without sufficient baking in 9.
> > webrev: http://cr.openjdk.java.net/~sla/8046024/webrev.00/
> > bug: https://bugs.openjdk.java.net/browse/JDK-8046024
> >
> Backing it out for now make sense to me, the change looks good.
Thanks Alan. I have filed a follow-up bug: \
https://bugs.openjdk.java.net/browse/JDK-8047334
/Staffan
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;"><br><div><div>On 19 jun 2014, at \
11:11, Alan Bateman <<a \
href="mailto:Alan.Bateman@oracle.com">Alan.Bateman@oracle.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: \
16px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: \
normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; \
-webkit-text-stroke-width: 0px;">On 19/06/2014 10:06, Staffan Larsen \
wrote:<br><blockquote type="cite">This fix was intended to catch a supposedly rare \
error return value from WaitForMultipleObjects in the shared memory transport for \
JDI. Unfortunately the error is not so rare (which should have been discovered during \
testing of the fix) and the fix has caused all the JDI tests on windows to become \
unstable.<br><br>While we investigate if the fix can be applied together with changes \
in the code (so that the error does not happen), I would like to backout the \
fix.<br><br>The backout will also have to be applied to 8u20 and 7u80 since the fix \
was backported there without sufficient baking in 9.<br><br>webrev: <a \
href="http://cr.openjdk.java.net/~sla/8046024/webrev.00/">http://cr.openjdk.java.net/~sla/8046024/webrev.00/</a><br>bug: \
<a href="https://bugs.openjdk.java.net/browse/JDK-8046024">https://bugs.openjdk.java.net/browse/JDK-8046024</a><br><br></blockquote>Backing \
it out for now make sense to me, the change looks \
good.<br></div></blockquote><div><br></div><div>Thanks Alan. I have filed a follow-up \
bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8047334">https://bugs.open \
jdk.java.net/browse/JDK-8047334</a></div><div><br></div><div>/Staffan</div><div><br></div></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic